Issue 207071: code review 207071: Fix syscall.Umask() for OS X and FreeBSD

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 207071: code review 207071: Fix syscall.Umask() for OS X and FreeBSD (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 2 months ago by giles

Modified:
15 years, 1 month ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

Fix syscall.Umask() for OS X and FreeBSD The existing code wasn't returning the old umask as it should. The new behaviour matches the Linux port. (n.b. A trivial fix, so didn't seem to need discussion first: if any proposed changes no matter how trivial should be discussed, let me know. Thanks.)

Patch Set 1 #

Created: 15 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -14 lines)			Patch
M	src/pkg/syscall/syscall_darwin.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/syscall/syscall_freebsd.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/syscall/zsyscall_darwin_386.go	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_darwin_amd64.go	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_freebsd_386.go	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_freebsd_amd64.go	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

giles

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 2 months ago (2010-02-11 23:55:21 UTC) #1

rsc

15 years, 2 months ago (2010-02-16 19:43:28 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=a39fec68d8fe ***

syscall: make signature of Umask on OS X, FreeBSD match Linux.

R=rsc
CC=golang-dev
http://codereview.appspot.com/207071

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages