Issue 207060: Send HTTP status codes with GadgetException throws

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 207060: Send HTTP status codes with GadgetException throws (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 11 months ago by johnfargo

Modified:
11 years, 4 months ago

Reviewers:
Paul Lindner, shindig.remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

This CL does change the status codes that will be emitted to the direct Shindig client. General guideline: * SC_BAD_REQUEST used when inputs are bad ie. query parameters or data provided by the gadget developer. * SC_BAD_GATEWAY used when data format (eg. FeedProcessor) is incorrect. The line is fuzzy, so I'm interested in input.

Patch Set 1 #

Created: 15 years, 11 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+50 lines, -36 lines)			Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractSpecFactory.java	View	1 chunk	+1 line, -1 line	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/FeedProcessor.java	View	2 chunks	+5 lines, -2 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultRequestPipeline.java	View	1 chunk	+4 lines, -2 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthArguments.java	View	2 chunks	+2 lines, -1 line	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaCssLexerParser.java	View	2 chunks	+3 lines, -1 line	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaCssParser.java	View	3 chunks	+4 lines, -3 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaHtmlParser.java	View	2 chunks	+5 lines, -2 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HtmlAccelServlet.java	View	1 chunk	+2 lines, -1 line	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java	View	5 chunks	+9 lines, -5 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyBase.java	View	4 chunks	+8 lines, -14 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java	View	2 chunks	+5 lines, -3 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/TemplateLibraryFactory.java	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

johnfargo

15 years, 11 months ago (2010-02-11 21:24:17 UTC) #3

Thanks for looking, Paul!  I've committed this CL.  Happy to accept
refinements over time.

On Thu, Feb 11, 2010 at 12:18 AM, <lindner@inuus.com> wrote:

> logic seems fine to me.
>
>
>
> http://codereview.appspot.com/207060/show
>

Expand All Messages | Collapse All Messages