Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(447)

Issue 206083: Improve computing of stock quantities (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 7 months ago by bch
Modified:
15 years, 7 months ago
Reviewers:
ced
Visibility:
Public.

Description

UNION ALL instead of UNION because we already know that there will not be duplicated results. Order = [] because the location ordering is not needed.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M product.py View 1 3 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 4
bch
15 years, 7 months ago (2010-02-12 11:29:17 UTC) #1
ced
http://codereview.appspot.com/206083/diff/1/2 File product.py (right): http://codereview.appspot.com/206083/diff/1/2#newcode417 product.py:417: "UNION ALL "\ Could you put a comment that ...
15 years, 7 months ago (2010-02-12 11:32:03 UTC) #2
bch
15 years, 7 months ago (2010-02-12 15:43:23 UTC) #3
ced
15 years, 7 months ago (2010-02-12 15:45:44 UTC) #4
Ok for me
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b