Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(82)

Issue 206082: Patch to temporarlilly revert SLING-1366, 1363 for release before JCR2 Update.

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 12 months ago by ianboston
Modified:
15 years, 12 months ago
Reviewers:
justinedelson
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Put SLING-1366 back in, AceTests failing #

Patch Set 3 : Fixed the Ace Errors #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -269 lines) Patch
M bundles/jcr/api/pom.xml View 2 chunks +4 lines, -4 lines 1 comment Download
M bundles/jcr/api/src/main/java/org/apache/sling/jcr/api/NamespaceMapper.java View 1 chunk +0 lines, -39 lines 1 comment Download
M bundles/jcr/api/src/main/java/org/apache/sling/jcr/api/SlingRepository.java View 1 chunk +0 lines, -6 lines 1 comment Download
M bundles/jcr/base/pom.xml View 2 chunks +3 lines, -3 lines 0 comments Download
M bundles/jcr/base/src/main/java/org/apache/sling/jcr/base/AbstractSlingRepository.java View 1 11 chunks +13 lines, -39 lines 0 comments Download
M bundles/jcr/base/src/main/java/org/apache/sling/jcr/base/SessionProxyHandler.java View 1 1 chunk +1 line, -5 lines 0 comments Download
A bundles/jcr/base/src/main/java/org/apache/sling/jcr/base/internal/NamespaceMapper.java View 1 chunk +32 lines, -0 lines 0 comments Download
M bundles/jcr/base/src/main/java/org/apache/sling/jcr/base/internal/loader/Loader.java View 1 chunk +1 line, -1 line 0 comments Download
M launchpad/builder/src/main/bundles/list.xml View 1 chunk +1 line, -6 lines 0 comments Download
M launchpad/test-services/pom.xml View 3 chunks +0 lines, -12 lines 1 comment Download
M launchpad/test-services/src/main/java/org/apache/sling/launchpad/testservices/jcr/TestNamespaceMapper.java View 1 chunk +0 lines, -40 lines 0 comments Download
M launchpad/test-services/src/main/java/org/apache/sling/launchpad/testservices/servlets/NamespaceTestServlet.java View 1 chunk +0 lines, -66 lines 1 comment Download
M launchpad/testing/src/test/java/org/apache/sling/launchpad/webapp/integrationtest/NamespaceMappingTest.java View 1 chunk +0 lines, -48 lines 3 comments Download

Messages

Total messages: 1
justinedelson
15 years, 12 months ago (2010-02-12 14:41:10 UTC) #1
jcr.api shouldn't be changed as it won't be released in the pre-jcr2 batch of
releases (jcr.api has been ready for jcr2 for a while now).

in addition, some of the namespace mapping test bits should be kept because they
test the Sling-Namespace manifest header. Just the parts related to the new(ish)
NamespaceMapper interface should be removed.

http://codereview.appspot.com/206082/diff/30/1014
File bundles/jcr/api/pom.xml (right):

http://codereview.appspot.com/206082/diff/30/1014#newcode10
bundles/jcr/api/pom.xml:10: 
no need to change this file at all. jcr.api won't be released.

http://codereview.appspot.com/206082/diff/30/1015
File bundles/jcr/api/src/main/java/org/apache/sling/jcr/api/NamespaceMapper.java
(left):

http://codereview.appspot.com/206082/diff/30/1015#oldcode2
bundles/jcr/api/src/main/java/org/apache/sling/jcr/api/NamespaceMapper.java:2: *
Licensed to the Apache Software Foundation (ASF) under one
No need to remove this file. jcr.api won't be released.

http://codereview.appspot.com/206082/diff/30/1016
File bundles/jcr/api/src/main/java/org/apache/sling/jcr/api/SlingRepository.java
(left):

http://codereview.appspot.com/206082/diff/30/1016#oldcode44
bundles/jcr/api/src/main/java/org/apache/sling/jcr/api/SlingRepository.java:44:
public interface SlingRepository extends Repository {
No reason to remove this comment. jcr.api won't be released.

http://codereview.appspot.com/206082/diff/30/1023
File launchpad/test-services/pom.xml (left):

http://codereview.appspot.com/206082/diff/30/1023#oldcode62
launchpad/test-services/pom.xml:62: </Sling-Namespaces>
This should be kept.

http://codereview.appspot.com/206082/diff/30/1025
File
launchpad/test-services/src/main/java/org/apache/sling/launchpad/testservices/servlets/NamespaceTestServlet.java
(left):

http://codereview.appspot.com/206082/diff/30/1025#oldcode2
launchpad/test-services/src/main/java/org/apache/sling/launchpad/testservices/servlets/NamespaceTestServlet.java:2:
* Licensed to the Apache Software Foundation (ASF) under one or more
No reason to remove this file.

http://codereview.appspot.com/206082/diff/30/1026
File
launchpad/testing/src/test/java/org/apache/sling/launchpad/webapp/integrationtest/NamespaceMappingTest.java
(left):

http://codereview.appspot.com/206082/diff/30/1026#oldcode24
launchpad/testing/src/test/java/org/apache/sling/launchpad/webapp/integrationtest/NamespaceMappingTest.java:24:
* Test that both Sling-Namespaces and {@link NamespaceMapper} work.
Just strike the "and {@link NamespaceMapper} work" bit

http://codereview.appspot.com/206082/diff/30/1026#oldcode31
launchpad/testing/src/test/java/org/apache/sling/launchpad/webapp/integrationtest/NamespaceMappingTest.java:31:
public void testNamespaceFromManifest() throws IOException {
This method should be kept. It's a useful test of the Sling-Namespaces namespace
registration method.

http://codereview.appspot.com/206082/diff/30/1026#oldcode41
launchpad/testing/src/test/java/org/apache/sling/launchpad/webapp/integrationtest/NamespaceMappingTest.java:41:
public void testNamespaceFromNamespaceMapper() throws IOException {
This method should be removed and reinstated post release of base.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b