Fix coding guidelines with pylint

[udono, 2010-02-10 21:44:19]

Looks good.

I like the more descriptive names a lot. And the cleanup of the imports is
great.

_ (=solely underscore) I have not seen before. It seems a convention for
syntactical needed variables which are not used. The other use is for gettext in
the client, but always like this _('translate me').

http://codereview.appspot.com/206063/diff/1/31
File trytond/tools/convert.py (right):

http://codereview.appspot.com/206063/diff/1/31#newcode277
trytond/tools/convert.py:277: self.mh.import_record( self.model._name,
self.values, self.xml_id)
a space to much

http://codereview.appspot.com/206063/diff/1/31#newcode1001
trytond/tools/convert.py:1001: 'Could not delete id: %d of model %s\n' \
the \ are not needed?

[yangoon1, 2010-02-11 00:26:20]

CHANGELOG? It is also slight refactoring.

http://codereview.appspot.com/206063/diff/2001/2002
File bin/trytond (right):

http://codereview.appspot.com/206063/diff/2001/2002#newcode3
bin/trytond:3: #this repository contains the full copyright notices and license
terms.
I would indeed prefer a space after # (block comments PEP8)

[ced, 2010-02-11 08:00:10]

http://codereview.appspot.com/206063/diff/2001/2002
File bin/trytond (right):

http://codereview.appspot.com/206063/diff/2001/2002#newcode3
bin/trytond:3: #this repository contains the full copyright notices and license
terms.
On 2010/02/11 00:26:20, yangoon wrote:
> I would indeed prefer a space after # (block comments PEP8)

copyright notice is not part of the code so I don't think we will win in
readability.
So I think we can make an exception to PEP8 for the copyright notice in Tryton.

[yangoon1, 2010-02-11 09:40:57]

On 2010/02/11 08:00:10, ced wrote:
> http://codereview.appspot.com/206063/diff/2001/2002
> File bin/trytond (right):
> 
> http://codereview.appspot.com/206063/diff/2001/2002#newcode3
> bin/trytond:3: #this repository contains the full copyright notices and
license
> terms.
> On 2010/02/11 00:26:20, yangoon wrote:
> > I would indeed prefer a space after # (block comments PEP8)
> 
> copyright notice is not part of the code so I don't think we will win in
> readability.

Uniform code is always better readable. And if I would be ced ;) I would say: a
block comment is a block comment, whether it is at the beginning or not.

> So I think we can make an exception to PEP8 for the copyright notice in
Tryton.

Of course you can make, but I don't see any sense why we should make this
exception (except that it has to be changed in all files).

JFTR: It is of course not substantial, but if we are nitpicking on coding
guidelines and stick very close to PEP8, we will avoid any discussions about
exceptions (/me remembering the discussion with htgoebel). 

I also forgot this:
Do we have empty line between copyright notice and first import or not?
It is not uniform through the code.

[ced, 2010-02-11 09:54:31]

On 2010/02/11 09:40:57, yangoon wrote:
> On 2010/02/11 08:00:10, ced wrote:
> > http://codereview.appspot.com/206063/diff/2001/2002
> > File bin/trytond (right):
> > 
> > http://codereview.appspot.com/206063/diff/2001/2002#newcode3
> > bin/trytond:3: #this repository contains the full copyright notices and
> license
> > terms.
> > On 2010/02/11 00:26:20, yangoon wrote:
> > > I would indeed prefer a space after # (block comments PEP8)
> > 
> > copyright notice is not part of the code so I don't think we will win in
> > readability.
> 
> Uniform code is always better readable. And if I would be ced ;) I would say:
a
> block comment is a block comment, whether it is at the beginning or not.
> 
> > So I think we can make an exception to PEP8 for the copyright notice in
> Tryton.
> 
> Of course you can make, but I don't see any sense why we should make this
> exception (except that it has to be changed in all files).

There is already exception for the shebang.

> 
> JFTR: It is of course not substantial, but if we are nitpicking on coding
> guidelines and stick very close to PEP8, we will avoid any discussions about
> exceptions (/me remembering the discussion with htgoebel).

It is not that we stick strictly close to PEP8 (we had already exceptions).
But there is the existing code and we should deal with it.

 
> 
> I also forgot this:
> Do we have empty line between copyright notice and first import or not?

It is not yet specified.

> It is not uniform through the code.

PS: reply to the comment not globally.