Issue 2051041: code review 2051041: http: add Date to server, Last-Modified and If-Modified...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2051041: code review 2051041: http: add Date to server, Last-Modified and If-Modified... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 6 months ago by rsc

Modified:
14 years, 6 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

http: add Date to server, Last-Modified and If-Modified-Since to file server

Patch Set 2 : code review 2051041: http: add Date to server, Last-Modified and If-Modified... #

Total comments: 2

Patch Set 3 : code review 2051041: http: add Date to server, Last-Modified and If-Modified... #

Created: 14 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -24 lines)			Patch
M	src/pkg/http/fs.go	View	1	5 chunks	+10 lines, -4 lines	0 comments	Download
M	src/pkg/http/server.go	View	1 2	2 chunks	+7 lines, -0 lines	0 comments	Download
M	src/pkg/http/triv.go	View		3 chunks	+3 lines, -20 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 6 months ago (2010-08-27 16:57:14 UTC) #1

LGTM http://codereview.appspot.com/2051041/diff/2001/3002 File src/pkg/http/server.go (right): http://codereview.appspot.com/2051041/diff/2001/3002#newcode107 src/pkg/http/server.go:107: // It like time.RFC1123 but hard codes GMT ...

14 years, 6 months ago (2010-08-27 21:35:26 UTC) #2

rsc

14 years, 6 months ago (2010-09-02 18:21:13 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=01a0838d243a ***

http: add Date to server, Last-Modified and If-Modified-Since to file server

R=r
CC=golang-dev
http://codereview.appspot.com/2051041

Expand All Messages | Collapse All Messages