Issue 2049042: Add timeout to socket.accept in netrpc to fix issue1625

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2049042: Add timeout to socket.accept in netrpc to fix issue1625 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 5 months ago by pheller

Modified:
15 years, 4 months ago

Reviewers:
pheller, ced, yangoon1

Visibility:
Public.

Patch Set 2 : Fixed CHANGELOG #

Total comments: 2

Patch Set 3 : Fixes per ced #

Created: 15 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	trytond/protocols/netrpc.py	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

ced

http://codereview.appspot.com/2049042/diff/2001/3001 File CHANGELOG (right): http://codereview.appspot.com/2049042/diff/2001/3001#newcode1 CHANGELOG:1: * Bug fixes (see mercurial logs for details) We ...

15 years, 5 months ago (2010-08-29 07:22:41 UTC) #2

ced

Looks good. But we must way to have enough test before including it as it ...

15 years, 5 months ago (2010-08-29 13:38:07 UTC) #4

pheller_me.com

I completely understand. Will test with centos and fedora tonight. Regards, --phil On Aug 29, ...

15 years, 5 months ago (2010-08-29 14:17:23 UTC) #5

ced

15 years, 4 months ago (2010-09-25 15:33:43 UTC) #6

Work for me on Gentoo/Linux
You can submit a patch for trunk

Expand All Messages | Collapse All Messages