Issue 2043041: code review 2043041: build: remove unnecessary references to GOBIN and GOROOT

Issue 2043041: code review 2043041: build: remove unnecessary references to GOBIN and GOROOT (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by chressie

Modified:
13 years, 8 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

build: remove unnecessary references to GOBIN and GOROOT All scripts and makefiles assume that GOBIN is correctly set in PATH.

Patch Set 2 : code review 2043041: build: remove unnecessary references to GOBIN #

Total comments: 2

Patch Set 3 : code review 2043041: build: remove unnecessary references to GOBIN and GOROOT #

Total comments: 3

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -77 lines)			Patch
M	doc/Makefile	View		1 chunk	+2 lines, -2 lines	1 comment	Download
M	doc/codelab/wiki/Makefile	View	1 2	2 chunks	+4 lines, -9 lines	1 comment	Download
M	doc/progs/run	View		4 chunks	+5 lines, -7 lines	0 comments	Download
M	misc/cgo/stdio/Makefile	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	misc/cgo/stdio/test.bash	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	src/Make.common	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/clean.bash	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/gc/mkbuiltin	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/make.bash	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/exp/eval/Makefile	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/pkg/exp/eval/test.bash	View		1 chunk	+2 lines, -4 lines	0 comments	Download
M	src/pkg/exp/ogle/Makefile	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/image/jpeg/Makefile	View		2 chunks	+2 lines, -2 lines	1 comment	Download
M	src/pkg/runtime/Makefile	View		2 chunks	+10 lines, -10 lines	0 comments	Download
M	src/quietgcc.bash	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/run.bash	View		2 chunks	+16 lines, -16 lines	0 comments	Download
M	test/bench/timing.sh	View		2 chunks	+3 lines, -5 lines	0 comments	Download
M	test/run	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	test/run-arm	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

chressie

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

13 years, 8 months ago (2010-08-27 06:12:27 UTC) #1

rsc1

LGTM one nit http://codereview.appspot.com/2043041/diff/2001/3001 File doc/codelab/wiki/Makefile (right): http://codereview.appspot.com/2043041/diff/2001/3001#newcode9 doc/codelab/wiki/Makefile:9: # ugly hack to deal with ...

13 years, 8 months ago (2010-08-27 15:30:03 UTC) #2

chressie

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 8 months ago (2010-08-30 06:27:17 UTC) #3

chressie

i removed some unnecessary GOROOT references, as well. hope that's fine cheers, chressie http://codereview.appspot.com/2043041/diff/2001/3001 File ...

13 years, 8 months ago (2010-08-30 06:35:32 UTC) #4

rsc

13 years, 8 months ago (2010-08-30 19:41:02 UTC) #6

*** Submitted as fc78265a7673 ***

build: remove unnecessary references to GOBIN and GOROOT

All scripts and makefiles assume that GOBIN is correctly set
in PATH.

R=rsc
CC=golang-dev
http://codereview.appspot.com/2043041

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages