code review 204065: runtime: allow arbitrary return type in SetFinalizer.

src/pkg/runtime/chan.c

 // Copyright 2009 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 #include "runtime.h"
 #include "type.h"
 
 static  int32   debug   = 0;
 
 enum
@@ skipping 68 matching lines @@
         Scase*  scase[1];               // one per case
 };
 
 static  SudoG*  dequeue(WaitQ*, Hchan*);
 static  void    enqueue(WaitQ*, SudoG*);
 static  SudoG*  allocsg(Hchan*);
 static  void    freesg(Hchan*, SudoG*);
 static  uint32  gcd(uint32, uint32);
 static  uint32  fastrand1(void);
 static  uint32  fastrand2(void);
+static  void    destroychan(Hchan*);
 
 Hchan*
 makechan(Type *elem, uint32 hint)
 {
         Hchan *c;
         int32 i;
 
         if(elem->alg >= nelem(algarray)) {
                 printf("chan(alg=%d)\n", elem->alg);
                 throw("runtime.makechan: unsupported elem type");
         }
 
         c = mal(sizeof(*c));
+        addfinalizer(c, destroychan, 0);

[cw, 2010/02/09 05:50:19]

is there a clean way to do this for darwin only?  it seems pointless to have the
empty stub functions in freebsd and linux

 
         c->elemsize = elem->size;
         c->elemalg = &algarray[elem->alg];
         c->elemalign = elem->align;
 
         if(hint > 0) {
                 Link *d, *b, *e;
 
                 // make a circular q
                 b = nil;
@@ skipping 22 matching lines @@
                 prints("; elemalign=");
                 ·printint(elem->align);
                 prints("; dataqsiz=");
                 ·printint(c->dataqsiz);
                 prints("\n");
         }
 
         return c;
 }
 
+static void
+destroychan(Hchan *c)
+{
+        destroylock(&c->Lock);
+}
+
+
 // makechan(elemsize uint32, elemalg uint32, hint uint32) (hchan *chan any);
 void
 ·makechan(Type *elem, uint32 hint, Hchan *ret)
 {
         ret = makechan(elem, hint);
         FLUSH(&ret);
 }
 
 static void
 incerr(Hchan* c)
@@ skipping 922 matching lines @@
 static uint32
 fastrand2(void)
 {
         static uint32 x = 0x49f6428aUL;
 
         x += x;
         if(x & 0x80000000L)
                 x ^= 0xfafd871bUL;
         return x;
 }