code review 204044: *l/*c: add -V flag to display version number

*l/*c: add -V flag to display version number

[adg, 2010-02-06 00:11:09]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc, 2010-02-06 00:23:13]

http://codereview.appspot.com/204044/diff/1/5
File src/cmd/gc/lex.c (right):

http://codereview.appspot.com/204044/diff/1/5#newcode69
src/cmd/gc/lex.c:69: print("%cg verison %s\n", thechar, getgoversion());
version

http://codereview.appspot.com/204044/diff/1/5#newcode174
src/cmd/gc/lex.c:174: print("  -V print the version number of %cg\n", thechar);
print the compiler version

http://codereview.appspot.com/204044/diff/1/8
File src/make.bash (right):

http://codereview.appspot.com/204044/diff/1/8#newcode49
src/make.bash:49: export GOVERSION="`./version.bash`"
It would be good to move this into lib9 and call it
from the Makefile.  If I run make in lib9 by hand
GOVERSION won't be set at all.

http://codereview.appspot.com/204044/diff/1/9
File src/version.bash (right):

http://codereview.appspot.com/204044/diff/1/9#newcode1
src/version.bash:1: #!/usr/bin/env bash
Should move script to lib9

http://codereview.appspot.com/204044/diff/1/9#newcode2
src/version.bash:2: # Copyright 2009 The Go Authors. All rights reserved.
Copyright 2010

http://codereview.appspot.com/204044/diff/1/9#newcode8
src/version.bash:8: echo "unknown"
echo 'hg not installed' 1>&2
exit 2

http://codereview.appspot.com/204044/diff/1/9#newcode16
src/version.bash:16: TAG="`hg identify -t`"
TAG=$(hg identify -t | sed 's!/release!!')

[rsc, 2010-02-06 00:23:47]

Also please update src/cmd/*/doc.go as appropriate.

[adg, 2010-02-06 02:20:16]

Hello rsc (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2010-02-06 02:22:10]

LGTM

It is worth doing a build on the other architecture just
to double check.  So if you've been
using GOARCH=amd64, try

    cd $GOROOT
    GOARCH=386 ./all.bash

or vice versa.

Russ

[adg, 2010-02-08 17:46:56]

*** Submitted as http://code.google.com/p/go/source/detail?r=f007a43a1b44 ***

*l/*c: add -V flag to display version number

R=rsc
CC=golang-dev
http://codereview.appspot.com/204044