Issue 203060: code review 203060: 8l: pe executable building code changed to include impo...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 203060: code review 203060: 8l: pe executable building code changed to include impo... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by brainman

Modified:
14 years, 1 month ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

8l: pe executable building code changed to include import table for kernel32.dll functions Fixes issue 586.

Patch Set 1 #

Patch Set 2 : code review 203060: 8l: pe executable building code changed to include impo... #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -0 lines)			Patch
	M	src/cmd/ld/pe.h	View		2 chunks	+25 lines, -0 lines	0 comments	Download
	M	src/cmd/ld/pe.c	View		2 chunks	+74 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

brainman

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 3 months ago (2010-02-08 00:09:16 UTC) #1

rsc

Seems reasonable, thanks. Could you please complete the CLA as described at http://golang.org/doc/contribute.html#copyright ? Thanks. ...

14 years, 3 months ago (2010-02-10 01:39:17 UTC) #2

brainman

On 2010/02/10 01:39:17, rsc wrote: > Could you please complete the CLA as described at ...

14 years, 3 months ago (2010-02-10 04:16:05 UTC) #3

rsc

14 years, 3 months ago (2010-02-10 08:47:54 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=38e16beed2af ***

8l: pe executable building code changed to include import table for kernel32.dll
functions

Fixes issue 586.

R=rsc
CC=golang-dev
http://codereview.appspot.com/203060

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages