Issue 2024041: Upgrade caja

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2024041: Upgrade caja (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 4 months ago by Jasvir

Modified:
15 years, 4 months ago

Reviewers:
Paul Lindner, zhoresh, gagan.goku

CC:
shindig.remailer_gmail.com

Base URL:
https://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

* Stop throwing runtime errors in the css parser * rename HTMLElement.{g,s}etStyle method to avoid conflicts * Fix entity name handling in HTML. * Be more tolerant when parsing doctypes

Patch Set 1 #

Created: 15 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	pom.xml	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gagan.goku

On 2010/08/24 06:43:11, jasvir wrote: > LGTM. Since we have been tracking some of the ...

15 years, 4 months ago (2010-08-24 07:04:23 UTC) #2

Paul Lindner

okay, seems fine. Does it fix the ignored caja test in CajaSocialMarkupHtmlParserTest?

15 years, 4 months ago (2010-08-24 07:16:08 UTC) #3

jas_nagras.com

15 years, 4 months ago (2010-08-24 08:08:33 UTC) #4

On Tue, Aug 24, 2010 at 12:16 AM, <lindner@inuus.com> wrote:

> okay, seems fine.
>
> Does it fix the ignored caja test in CajaSocialMarkupHtmlParserTest?


No it does not but it should be part of the next push from Caja.


>
>
> http://codereview.appspot.com/2024041/
>

Expand All Messages | Collapse All Messages