Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(115)

Issue 2018042: Fix spelling of "ounce" per issue1414 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 5 months ago by pheller
Modified:
15 years, 4 months ago
Reviewers:
ced, yangoon1
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Added migration for ir_model_data #

Total comments: 2

Patch Set 3 : Fixes per ced, tested and successfully modifies database on upgrade #

Total comments: 2

Patch Set 4 : Migration moved to after super init, eliminated unnecessary arg to cr.execute #

Patch Set 5 : Oops, forgot to save before upload.py! #

Total comments: 1

Patch Set 6 : put call to init super() at end of module init #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M de_DE.csv View 2 chunks +2 lines, -2 lines 0 comments Download
M es_CO.csv View 2 chunks +2 lines, -2 lines 0 comments Download
M es_ES.csv View 2 chunks +2 lines, -2 lines 0 comments Download
M fr_FR.csv View 2 chunks +2 lines, -2 lines 0 comments Download
M uom.py View 2 3 4 5 1 chunk +8 lines, -0 lines 0 comments Download
M uom.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12
pheller
15 years, 5 months ago (2010-08-20 16:29:29 UTC) #1
yangoon1
I think database migration is needed.
15 years, 5 months ago (2010-08-20 16:38:44 UTC) #2
ced
You need to update ir.model.data to prevent the suppression of the old record.
15 years, 5 months ago (2010-08-20 16:43:29 UTC) #3
pheller
15 years, 4 months ago (2010-09-16 15:15:51 UTC) #4
ced
http://codereview.appspot.com/2018042/diff/5001/uom.py File uom.py (right): http://codereview.appspot.com/2018042/diff/5001/uom.py#newcode50 uom.py:50: def init(self, module_name): You must call super http://codereview.appspot.com/2018042/diff/5001/uom.py#newcode56 uom.py:56: ...
15 years, 4 months ago (2010-09-16 15:56:56 UTC) #5
pheller
15 years, 4 months ago (2010-09-16 18:20:41 UTC) #6
ced
http://codereview.appspot.com/2018042/diff/11001/uom.py File uom.py (right): http://codereview.appspot.com/2018042/diff/11001/uom.py#newcode56 uom.py:56: (module_name,)) There is no need to params for execute. ...
15 years, 4 months ago (2010-09-16 21:42:22 UTC) #7
pheller
15 years, 4 months ago (2010-09-16 21:59:49 UTC) #8
pheller
15 years, 4 months ago (2010-09-16 22:01:12 UTC) #9
ced
http://codereview.appspot.com/2018042/diff/19001/uom.py File uom.py (right): http://codereview.appspot.com/2018042/diff/19001/uom.py#newcode51 uom.py:51: super(Uom, self).init(module_name) Oops sorry, you was right the super ...
15 years, 4 months ago (2010-09-17 05:23:28 UTC) #10
pheller
15 years, 4 months ago (2010-09-17 14:07:09 UTC) #11
ced
15 years, 4 months ago (2010-09-19 07:59:38 UTC) #12
Looks ok for me
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b