Remove form-based issue upload/updating.

Remove form-based issue upload/updating.

Doesn't remove as much cruft as I had hoped, but it's still less cruft.

R=maruel@chromium.org
BUG=

[iannucci, 2013-10-31 01:49:14]

https://codereview.appspot.com/20120043/diff/1/codereview/urls.py
File codereview/urls.py (right):

https://codereview.appspot.com/20120043/diff/1/codereview/urls.py#newcode41
codereview/urls.py:41: (r'^(\d+)/(?:show)?$', 'show'),
This previously was passing the string 'show' to the 'form' parameter of the
show() method in views.py.

[M-A, 2013-10-31 17:52:42]

+ codereview-discuss@googlegroups.com

This CL removes the manual upload of diffs. It provided little value and we
don't want to encourage fetching base file from a remote SCM.

If you have any concern, please voice them immediately. Otherwise, lgtm.

[Andi, 2013-10-31 18:25:24]

We've thought about removing the upload form several times in the past few
years, but we were always to anxious to actually remove it. From my personal
experience (and why I didn't removed it yet) there were always some users that
used it.

But, hey, it's Halloween! So no need to be afraid anymore :) Let's remove it!

https://codereview.appspot.com/20120043/diff/1/codereview/views.py
File codereview/views.py (right):

https://codereview.appspot.com/20120043/diff/1/codereview/views.py#newcode980
codereview/views.py:980: return
HttpResponseRedirect(reverse(customized_upload_py))
IMO it's a bit harsh to simply redirect the user to an download of "some python
file called upload.py" (that counts for new users) when he clicks on "Create
Issue".

I'd propose to show a intermediate page with a download link for upload.py and a
link to https://code.google.com/p/rietveld/wiki/UploadPyUsage

[iannucci, 2013-11-01 09:35:18]

https://codereview.appspot.com/20120043/diff/1/codereview/views.py
File codereview/views.py (right):

https://codereview.appspot.com/20120043/diff/1/codereview/views.py#newcode980
codereview/views.py:980: return
HttpResponseRedirect(reverse(customized_upload_py))
On 2013/10/31 18:25:24, Andi wrote:
> IMO it's a bit harsh to simply redirect the user to an download of "some
python
> file called upload.py" (that counts for new users) when he clicks on "Create
> Issue".
> 
> I'd propose to show a intermediate page with a download link for upload.py and
a
> link to https://code.google.com/p/rietveld/wiki/UploadPyUsage

Ah, this only happens if we're POSTing, which can only happen if they click the
download button on the 'use_uploadpy.html'. 

On an unrelated note, I'm really not a fan of the
one-function-handles-both-POST-and-GET style :/. It's tripped me up more than
once.

[Andi, 2013-11-01 09:36:44]

LGTM

https://codereview.appspot.com/20120043/diff/1/codereview/views.py
File codereview/views.py (right):

https://codereview.appspot.com/20120043/diff/1/codereview/views.py#newcode980
codereview/views.py:980: return
HttpResponseRedirect(reverse(customized_upload_py))
On 2013/11/01 09:35:19, iannucci wrote:
> On 2013/10/31 18:25:24, Andi wrote:
> > IMO it's a bit harsh to simply redirect the user to an download of "some
> python
> > file called upload.py" (that counts for new users) when he clicks on "Create
> > Issue".
> > 
> > I'd propose to show a intermediate page with a download link for upload.py
and
> a
> > link to https://code.google.com/p/rietveld/wiki/UploadPyUsage
> 
> Ah, this only happens if we're POSTing, which can only happen if they click
the
> download button on the 'use_uploadpy.html'. 
> 
> On an unrelated note, I'm really not a fan of the
> one-function-handles-both-POST-and-GET style :/. It's tripped me up more than
> once.

sorry, missed that too :)

[iannucci, 2013-11-02 01:06:02]

Committed
https://code.google.com/p/rietveld/source/detail?r=5142e8db5f9119ce4cfa1b0e16...
Merged
https://code.google.com/p/rietveld/source/detail?r=7b0f42dc8d33840ca943715a11...