Issue 201068: code review 201068: math: Atan2 special cases and tests; atan2_386

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 201068: code review 201068: math: Atan2 special cases and tests; atan2_386 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by Charlie Dorian

Modified:
15 years, 1 month ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

math: Atan2 special cases and tests; atan2_386 Added special cases, tests and benchmarks for Atan2; added 386 FPU version of Atan2.

Patch Set 2 : code review 201068: math: Atan2 special cases and tests; atan2_386 #

Total comments: 1

Patch Set 3 : code review 201068: math: Atan2 special cases and tests; atan2_386 #

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+166 lines, -3 lines)			Patch
M	src/pkg/math/Makefile	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/math/all_test.go	View		4 chunks	+89 lines, -0 lines	0 comments	Download
M	src/pkg/math/atan2.go	View	1 2	1 chunk	+58 lines, -3 lines	0 comments	Download
A	src/pkg/math/atan2_386.s	View	1 2	1 chunk	+11 lines, -0 lines	0 comments	Download
A	src/pkg/math/atan2_decl.go	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Charlie Dorian

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 1 month ago (2010-02-05 18:59:32 UTC) #1

rsc

http://codereview.appspot.com/201068/diff/12/1003 File src/pkg/math/atan2.go (right): http://codereview.appspot.com/201068/diff/12/1003#newcode11 src/pkg/math/atan2.go:11: // Special cases are: I think this simplifies to ...

15 years, 1 month ago (2010-02-05 22:25:18 UTC) #2

Charlie Dorian

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

15 years, 1 month ago (2010-02-05 22:51:02 UTC) #3

Charlie Dorian

Thanks. On Fri, Feb 5, 2010 at 5:25 PM, <rsc@golang.org> wrote: > > http://codereview.appspot.com/201068/diff/12/1003 > ...

15 years, 1 month ago (2010-02-05 22:53:40 UTC) #4

rsc

15 years, 1 month ago (2010-02-05 22:55:21 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=62e7a410b13e ***

math: Atan2 special cases and tests; atan2_386

Added special cases, tests and benchmarks for Atan2;
added 386 FPU version of Atan2.

R=rsc
CC=golang-dev
http://codereview.appspot.com/201068

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages