Add MySQL backend to Tryton

- lock doesn't work due because http://forums.mysql.com/read.php?21,106838,106838
- test0030float doesn't work because http://dev.mysql.com/doc/refman/5.0/en/problems-with-float.html
- backup/restore not yet implemented

[yangoon1, 2010-02-07 22:53:25]

http://codereview.appspot.com/201067/diff/1/7
File trytond/backend/mysql/database.py (right):

http://codereview.appspot.com/201067/diff/1/7#newcode6
trytond/backend/mysql/database.py:6: import MySQLdb
MySQLdb should also be in extras_require in setup.py
and mentionend as Optional in INSTALL

http://codereview.appspot.com/201067/diff/1/7#newcode150
trytond/backend/mysql/database.py:150: self.dbname =self.database_name #XXX to
remove
missing space after =

http://codereview.appspot.com/201067/diff/1/10
File trytond/backend/mysql/table.py (right):

http://codereview.appspot.com/201067/diff/1/10#newcode23
trytond/backend/mysql/table.py:23: if not self.history:
AFAIS if history defined, the normal table won't be created, only history table.

http://codereview.appspot.com/201067/diff/1/10#newcode123
trytond/backend/mysql/table.py:123: conname, contype = line
constrname, constrtype?
I know it is the same in other backends, but it would be better to avoid
confusion with con(nection)name...

http://codereview.appspot.com/201067/diff/1/10#newcode192
trytond/backend/mysql/table.py:192: #Migrate size
space after #

http://codereview.appspot.com/201067/diff/1/10#newcode304
trytond/backend/mysql/table.py:304: 'ALTER TABLE `%s` ALTER COLUMN `%s` SET NOT
NULL' % \
manual command does not match MySQL as used above

http://codereview.appspot.com/201067/diff/1/10#newcode324
trytond/backend/mysql/table.py:324: # This constrain already exist
This constraint already exists

http://codereview.appspot.com/201067/diff/1/12
File trytond/model/modelsql.py (right):

http://codereview.appspot.com/201067/diff/1/12#newcode149
trytond/model/modelsql.py:149: field_name, action=required and 'add' or
'remove')
Strictly speaking this is not part of changeset Add MySQL backend to Tryton, but
a different one.

[ced, 2010-02-08 08:42:58]

http://codereview.appspot.com/201067/diff/1/10
File trytond/backend/mysql/table.py (right):

http://codereview.appspot.com/201067/diff/1/10#newcode23
trytond/backend/mysql/table.py:23: if not self.history:
On 2010/02/07 22:53:25, yangoon wrote:
> AFAIS if history defined, the normal table won't be created, only history
table.
No, history means we work on the history table.

http://codereview.appspot.com/201067/diff/1/12
File trytond/model/modelsql.py (right):

http://codereview.appspot.com/201067/diff/1/12#newcode149
trytond/model/modelsql.py:149: field_name, action=required and 'add' or
'remove')
On 2010/02/07 22:53:25, yangoon wrote:
> Strictly speaking this is not part of changeset Add MySQL backend to Tryton,
but
> a different one.

Will be remove once http://codereview.appspot.com/204074 will be applied.

[yangoon1, 2010-02-09 11:05:32]

Don't have mysql running, so cannot test, but loks ok for me.

http://codereview.appspot.com/201067/diff/3001/4008
File trytond/backend/mysql/database.py (right):

http://codereview.appspot.com/201067/diff/3001/4008#newcode57
trytond/backend/mysql/database.py:57: #TODO restore
what will currently happen, when the user tries to use this?

[mbayer, 2010-02-18 11:36:01]

I've just tested the patch (applied to current trunk) against a mysql5 server.

-> Database creation works
-> Module installation works (tested all modules except account_be and skr)

There is an error when specifying the db_port:
db_port = 3306
returns an "integer required" error in the client
i suggest turning "args['port'] = CONFIG['db_port']" in database.py to
"args['port'] = int(CONFIG['db_port'])" should fix it?

Is it possible to not just return the mysql error numbers to the client? ->
please add the clear text error description from the mySQLdb module too.
I just got two errors in the client while testing:
2005
1045
i guessed they were mysql error #'s and i was right. ;-)

[ced, 2010-02-18 12:50:12]

On 2010/02/18 11:36:01, mbayer wrote:
> I've just tested the patch (applied to current trunk) against a mysql5 server.
> 
> -> Database creation works
> -> Module installation works (tested all modules except account_be and skr)
> 
> There is an error when specifying the db_port:
> db_port = 3306
> returns an "integer required" error in the client
> i suggest turning "args['port'] = CONFIG['db_port']" in database.py to
> "args['port'] = int(CONFIG['db_port'])" should fix it?
> 
> Is it possible to not just return the mysql error numbers to the client? ->
> please add the clear text error description from the mySQLdb module too.
> I just got two errors in the client while testing:
> 2005
> 1045
> i guessed they were mysql error #'s and i was right. ;-)

Any hints on how to retrieve error message from MySQL?

[mbayer, 2010-02-18 16:41:26]

Hi !

> Any hints on how to retrieve error message from MySQL?
I think the tryton server only returns element 0 of e.args (the error number)

   except MySQLdb.Error, e:
     print "Error %d: %s" % (e.args[0], e.args[1])

should print error number and clear text

[ced, 2010-02-23 14:49:24]

Somebody tested the last version?

[bch, 2010-02-25 13:33:05]

http://codereview.appspot.com/201067/diff/10001/10004
File README (right):

http://codereview.appspot.com/201067/diff/10001/10004#newcode43
README:43: * There is problems with floating-point comparisons.
"There are problems" or "There is a problem"

http://codereview.appspot.com/201067/diff/10001/10004#newcode45
README:45: 
Maybe add sqlite and say that it doesn't support concurrent queries and so is
restricted for light usage.

[ced, 2010-02-25 13:35:16]

http://codereview.appspot.com/201067/diff/10001/10004
File README (right):

http://codereview.appspot.com/201067/diff/10001/10004#newcode45
README:45: 
On 2010/02/25 13:33:05, bch wrote:
> Maybe add sqlite and say that it doesn't support concurrent queries and so is
> restricted for light usage.

For an other patch

[udono, 2010-02-25 14:16:44]

ok for me.

http://codereview.appspot.com/201067/diff/10001/10004
File README (right):

http://codereview.appspot.com/201067/diff/10001/10004#newcode45
README:45: 
slightly better then restricting to "light usage" is restricting to "single
user".

[ced, 2010-02-25 14:20:41]

http://codereview.appspot.com/201067/diff/10001/10004
File README (right):

http://codereview.appspot.com/201067/diff/10001/10004#newcode45
README:45: 
On 2010/02/25 14:16:44, udono wrote:
> slightly better then restricting to "light usage" is restricting to "single
> user".

We will talk about that on the other patch. But sqlite is not restricted to
single user.

[bch, 2010-02-25 14:36:54]

http://codereview.appspot.com/201067/diff/11005/11008
File README (right):

http://codereview.appspot.com/201067/diff/11005/11008#newcode41
README:41: * The lock implementation of MySQL requires that Tryton lock all
tables.
that Tryton lockS

[bch, 2010-02-25 14:40:00]

On 2010/02/25 14:38:50, ced wrote:
> 

OK