Issue 201061: code review 201061: Match gccgo error messages.

Issue 201061: code review 201061: Match gccgo error messages. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by iant

Modified:
15 years, 1 month ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

Match gccgo error messages. bug121.go:12:3: error: name list not allowed in interface type bug121.go:16:2: error: expected signature or type name semi1.go:10:76: error: unexpected semicolon or newline before ‘{’ semi1.go:10:5: error: reference to undefined name ‘x’ semi1.go:10:8: error: reference to undefined name ‘y’ semi1.go:12:3: error: reference to undefined name ‘z’ semi2.go:10:79: error: unexpected semicolon or newline before ‘{’ semi2.go:10:9: error: reference to undefined name ‘x’ semi3.go:10:79: error: unexpected semicolon or newline before ‘{’ semi3.go:10:6: error: reference to undefined name ‘x’ semi3.go:10:9: error: reference to undefined name ‘y’ semi3.go:10:12: error: reference to undefined name ‘z’ semi3.go:12:3: error: reference to undefined name ‘z’ semi4.go:11:2: error: unexpected semicolon or newline before ‘{’ semi4.go:10:6: error: reference to undefined name ‘x’ semi4.go:12:3: error: reference to undefined name ‘z’ semi5.go:10:1: error: unexpected semicolon or newline before ‘{’ semi7.go:11:2: error: unexpected semicolon or newline before ‘else’ semi7.go:10:5: error: reference to undefined name ‘x’ slice.go:9:11: error: missing lower bound in slice expression slice.go:9:9: error: reference to undefined name ‘y’ slice.go:9:12: error: reference to undefined name ‘z’

Patch Set 1 #

Patch Set 2 : code review 201061: Match gccgo error messages. #

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -13 lines)			Patch
M	test/fixedbugs/bug121.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/syntax/semi1.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/syntax/semi2.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/syntax/semi3.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/syntax/semi4.go	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	test/syntax/semi5.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/syntax/semi7.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/syntax/slice.go	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

iant

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 1 month ago (2010-02-05 05:23:01 UTC) #1

iant

15 years, 1 month ago (2010-02-05 05:31:36 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=642f4440a578 ***

Match gccgo error messages.

bug121.go:12:3: error: name list not allowed in interface type
bug121.go:16:2: error: expected signature or type name

semi1.go:10:76: error: unexpected semicolon or newline before ‘{’
semi1.go:10:5: error: reference to undefined name ‘x’
semi1.go:10:8: error: reference to undefined name ‘y’
semi1.go:12:3: error: reference to undefined name ‘z’

semi2.go:10:79: error: unexpected semicolon or newline before ‘{’
semi2.go:10:9: error: reference to undefined name ‘x’

semi3.go:10:79: error: unexpected semicolon or newline before ‘{’
semi3.go:10:6: error: reference to undefined name ‘x’
semi3.go:10:9: error: reference to undefined name ‘y’
semi3.go:10:12: error: reference to undefined name ‘z’
semi3.go:12:3: error: reference to undefined name ‘z’

semi4.go:11:2: error: unexpected semicolon or newline before ‘{’
semi4.go:10:6: error: reference to undefined name ‘x’
semi4.go:12:3: error: reference to undefined name ‘z’

semi5.go:10:1: error: unexpected semicolon or newline before ‘{’

semi7.go:11:2: error: unexpected semicolon or newline before ‘else’
semi7.go:10:5: error: reference to undefined name ‘x’

slice.go:9:11: error: missing lower bound in slice expression
slice.go:9:9: error: reference to undefined name ‘y’
slice.go:9:12: error: reference to undefined name ‘z’

R=rsc
CC=golang-dev
http://codereview.appspot.com/201061

Expand All Messages | Collapse All Messages