Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(64)

Issue 201058: code review 201058: handle nils safely in Printf. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 12 months ago by r
Modified:
12 years, 12 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

handle nils safely in Printf. add some tests for erroneous formats.

Patch Set 1 #

Patch Set 2 : code review 201058: handle nils safely in Printf. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M src/pkg/fmt/fmt_test.go View 1 chunk +5 lines, -0 lines 0 comments Download
M src/pkg/fmt/print.go View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 3
r
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
12 years, 12 months ago (2010-02-05 00:18:49 UTC) #1
rsc
LGTM
12 years, 12 months ago (2010-02-05 00:20:35 UTC) #2
r
12 years, 12 months ago (2010-02-05 00:23:28 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=3c304a2dbfbc ***

handle nils safely in Printf.
add some tests for erroneous formats.

R=rsc
CC=golang-dev
http://codereview.appspot.com/201058
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b