code review 201043: syscall: on freebsd, darwin, give Kill same signature a...

syscall: on freebsd, darwin, give Kill same signature as on linux

[rsc, 2010-02-04 08:10:23]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[cw, 2010-02-04 08:45:51]

I did a simpler change dropping the third argument completely and using 0 on
darwin with no apparent ill effects.

I did this because the darwin manpage (man 2 kill) doesn't describe a third
argument --- where are the docs for this that you're using?

[rsc, 2010-02-04 09:27:28]

On Thu, Feb 4, 2010 at 00:45,  <cw@f00f.org> wrote:
> I did a simpler change dropping the third argument completely and using
> 0 on darwin with no apparent ill effects.
>
> I did this because the darwin manpage (man 2 kill) doesn't describe a
> third argument --- where are the docs for this that you're using?

There are no docs; I looked at the kernel sources.
If you specify 1 you get POSIX behavior, which
means it doesn't send to itself for kill(0, sig) and
it returns ESRCH instead of EPERM when there is
nothing to kill.

Russ

[r2, 2010-02-04 09:35:10]

LGTM

[cw, 2010-02-04 09:42:20]

> I'd like you to review this change.

LGTM (in so far as that the change matches your explanation and it works for me)

[cw, 2010-02-04 09:47:16]

Looking at the FreeBSD sources...

http://codereview.appspot.com/201043/diff/1007/1012
File src/pkg/syscall/zsyscall_freebsd_386.go (right):

http://codereview.appspot.com/201043/diff/1007/1012#newcode373
src/pkg/syscall/zsyscall_freebsd_386.go:373: func kill(pid int, signum int,
posix int) (errno int) {
i this really correct?  does freebsd really have this third argument?

http://fxr.watson.org/fxr/source/kern/init_sysent.c#L74
http://fxr.watson.org/fxr/ident?im=bigexcerpts;i=kill_args
http://fxr.watson.org/fxr/source/kern/kern_sig.c?im=bigexcerpts#L1685

i think it's probably just the freebsd port used some of the darwin files as a
template?

[rsc, 2010-02-04 10:06:12]

*** Submitted as http://code.google.com/p/go/source/detail?r=f807bec5cec1 ***

syscall: on freebsd, darwin, give Kill same signature as on linux

R=r, cw
CC=golang-dev
http://codereview.appspot.com/201043