Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(626)

Issue 20094: Review issue 4715 from the public Python tracker (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 5 months ago by Collin Winter
Modified:
9 years ago
Reviewers:
Jeffrey Yasskin
Base URL:
http://svn.python.org/view/*checkout*/python/trunk/
Visibility:
Public.

Patch Set 1 #

Total comments: 10
Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -174 lines) Patch
M Doc/library/dis.rst View 1 chunk +16 lines, -6 lines 0 comments Download
M Include/opcode.h View 1 chunk +5 lines, -3 lines 2 comments Download
M Lib/compiler/pyassem.py View 1 chunk +3 lines, -0 lines 0 comments Download
M Lib/compiler/pycodegen.py View 12 chunks +12 lines, -35 lines 0 comments Download
M Lib/opcode.py View 1 chunk +5 lines, -3 lines 0 comments Download
M Lib/test/test_dis.py View 1 chunk +15 lines, -17 lines 0 comments Download
M Lib/test/test_peepholer.py View 2 chunks +5 lines, -5 lines 4 comments Download
M Python/ceval.c View 5 chunks +67 lines, -17 lines 0 comments Download
M Python/compile.c View 18 chunks +33 lines, -53 lines 4 comments Download
M Python/import.c View 1 chunk +3 lines, -1 line 0 comments Download
M Python/peephole.c View 6 chunks +60 lines, -34 lines 0 comments Download

Messages

Total messages: 3
Collin Winter
Other than these little nits, looks good. http://codereview.appspot.com/20094/diff/1/6 File Include/opcode.h (right): http://codereview.appspot.com/20094/diff/1/6#newcode109 Line 109: #define ...
9 years, 5 months ago (2009-02-27 21:33:21 UTC) #1
Jeffrey Yasskin
Note that the original patch was at http://codereview.appspot.com/20064. I've updated the code at that one. ...
9 years, 5 months ago (2009-02-28 01:39:00 UTC) #2
Collin Winter
9 years, 5 months ago (2009-03-01 20:08:56 UTC) #3
LGTM sent on the http://codereview.appspot.com/20064 thread. Closing this issue.
Sorry I didn't see the other review issue.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b