Issue 200400043: Add further logging and use subprocess on cygwin.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 200400043: Add further logging and use subprocess on cygwin. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by M-A

Modified:
10 years, 4 months ago

Reviewers:
vadimsh

CC:
swarming-eng_googlegroups.com, sergiyb

Base URL:
https://code.google.com/p/swarming@2_align

Visibility:
Public.

More Reviews

Description

Add further logging and use subprocess on cygwin. Add process id to help figure out when processes change. I wrote that while diagnosing a problem, which eventually boiled down to broken uuid on cygwin x64 when libuuid-devel is missing. Argh. R=vadimsh@chromium.org BUG= Committed: https://code.google.com/p/swarming/source/detail?repo=default&r=1ace795efdf69e83cefb2c0cedaa60c19b0e4dfe

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -11 lines)			Patch
M	appengine/swarming/swarming_bot/__main__.py	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	appengine/swarming/swarming_bot/logging_utils.py	View	3 chunks	+13 lines, -7 lines	0 comments	Download
M	appengine/swarming/swarming_bot/logging_utils_test.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

M-A

10 years, 4 months ago (2015-02-12 19:17:03 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1ace795efdf69e83cefb2c0cedaa60c19b0e4dfe (presubmit successful).

Expand All Messages | Collapse All Messages