Issue 2000041: code review 2000041: fmt/print: remove a TODO regarding printing renamed byt...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2000041: code review 2000041: fmt/print: remove a TODO regarding printing renamed byt... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 7 months ago by r

Modified:
14 years, 7 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

fmt/print: remove a TODO regarding printing renamed byte slices. the solution must work around a weakness in the reflection library: there is no way to do type-safe conversions under reflection.

Patch Set 1 #

Patch Set 2 : code review 2000041: fmt/print: remove a TODO regarding printing renamed byt... #

Patch Set 3 : code review 2000041: fmt/print: remove a TODO regarding printing renamed byt... #

Patch Set 4 : code review 2000041: fmt/print: remove a TODO regarding printing renamed byt... #

Created: 14 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -3 lines)			Patch
	M	src/pkg/fmt/fmt_test.go	View		1 chunk	+1 line, -2 lines	0 comments	Download
	M	src/pkg/fmt/print.go	View	1 2	2 chunks	+17 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 7 months ago (2010-08-15 01:56:45 UTC) #1

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

14 years, 7 months ago (2010-08-15 05:57:12 UTC) #2

14 years, 7 months ago (2010-08-16 22:34:49 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=4e8eb9ad6e0d ***

fmt/print: remove a TODO regarding printing renamed byte slices.
the solution must work around a weakness in the reflection library:
there is no way to do type-safe conversions under reflection.

R=rsc
CC=golang-dev
http://codereview.appspot.com/2000041

Expand All Messages | Collapse All Messages