nested mercurial extension

[h.goebel, 2010-08-15 14:16:43]

Patch 5 fails for me
------------------------

** Unbekannter Fehler, Details folgen
[...]
** Python 2.6.4 (r264:75706, Jul 14 2010, 09:24:23) [GCC 4.4.1]
** Mercurial Distributed SCM (version 1.6.2)
** Erweiterungen geladen: nested
[...]
  File "/tmp/foo/nested.py", line 231, in test                  
    other = hg.repository(cmdutil.remoteui(repo, opts), dest)
AttributeError: 'module' object has no attribute 'remoteui'


Please add at least some brief Readme
--------------------------------------
e.g. I do not understand, why nested has to be put into the hgrc of each
sub-repo.


Clone soft-linked repos on filesystem-clone?
------------------------------------------------
I'm unsure whether its a good idea to clone repos which are soft-linked into the
toplevel repo (hg init beside; ln -s ../../../beside toplevel/d/d/). I normaly
use this to keep my own stuff out of the development tree of other stuff and to
avoid multiple copies.

http://codereview.appspot.com/1999041/diff/5/15002
File test-nested (right):

http://codereview.appspot.com/1999041/diff/5/15002#newcode8
test-nested:8: hg init --config ${CONFIG} toplevel
What is this --config for? It doe not seam to have any effect:

CONFIG="extensions.nested=${PWD}/nested.py"
hg init --config ${CONFIG} toplevel
hg init toplevel2
diff -r toplevel toplevel2/

shows no difference

http://codereview.appspot.com/1999041/diff/5/15002#newcode14
test-nested:14: hg init toplevel/d/d/r
Please use a loop here and more verbose file/dirnames. This would be much more
easy to understand (and to maintain).

http://codereview.appspot.com/1999041/diff/5/15002#newcode30
test-nested:30: hg commit --cwd toplevel/r/r -A -m "init"
IMHO at least on of these inits should use 
"-R toplevel/..." instead of "--cwd ..." just for the case, mercurial behaves
different here (or may some day).

http://codereview.appspot.com/1999041/diff/5/15002#newcode31
test-nested:31: 
Please add a test for a soft-linked repo here. forest has had a bug in this case
(endless recursion).

hg init beside
echo > beside/some-file "beside/some-file"
hg -R beside commit -m 'init'
ln -s ../../../beside toplevel/d/d/

http://codereview.appspot.com/1999041/diff/5/15002#newcode42
test-nested:42: hg nupdate --config ${CONFIG} --cwd toplevel-clone
When I do a 'diff -r toplevel toplevel-clone' here, I get a lot of differences I
can nit explain. E.g.:
"Only in toplevel/d/d/r/.hg: last-message.txt"

Some test for success/failure is missing in this test-script. How to measure
success?

[bch, 2010-08-17 21:43:58]

Everything seems to work ok when I use it in local or through ssh, except that
output are not colored (IE 'hg st' gives colored output, 'hg nst' does not).

When I try to nclone via http (after an hg serve in the source repo) the top
level repo is cloned but when accessing the first child repo the server output a
stack trace that seems to be a 404.

My mercurial version is 1.5.2, my hgrc is
"""
[ui]
username = Bertrand Chenal <bch@b2ck.com>
ignore = ~/.hgignore
merge = internal:merge

[extensions]
hgext.nested=/home/bch/.hgext/nested.py
color=

"""

Server logs:

127.0.1.1 - - [17/Aug/2010 23:41:44] "GET
/?pairs=0000000000000000000000000000000000000000-0000000000000000000000000000000000000000&cmd=between
HTTP/1.1" 200 -
127.0.1.1 - - [17/Aug/2010 23:41:44] "GET /?cmd=capabilities HTTP/1.1" 200 -
127.0.1.1 - - [17/Aug/2010 23:41:44] "GET /?cmd=nested HTTP/1.1" 200 -
127.0.1.1 - - [17/Aug/2010 23:41:44] "GET
/?pairs=0000000000000000000000000000000000000000-0000000000000000000000000000000000000000&cmd=between
HTTP/1.1" 200 -
127.0.1.1 - - [17/Aug/2010 23:41:44] "GET /?cmd=heads HTTP/1.1" 200 -
127.0.1.1 - - [17/Aug/2010 23:41:44] "GET
/?cmd=changegroup&roots=0000000000000000000000000000000000000000 HTTP/1.1" 200 -
----------------------------------------
Exception happened during processing of request from ('127.0.1.1', 34540)
Traceback (most recent call last):
  File "/usr/lib/python2.5/SocketServer.py", line 464, in process_request_thread
    self.finish_request(request, client_address)
  File "/usr/lib/python2.5/SocketServer.py", line 254, in finish_request
    self.RequestHandlerClass(request, client_address, self)
  File "/usr/lib/pymodules/python2.5/mercurial/hgweb/server.py", line 44, in
__init__
    BaseHTTPServer.BaseHTTPRequestHandler.__init__(self, *args, **kargs)
  File "/usr/lib/python2.5/SocketServer.py", line 522, in __init__
    self.handle()
  File "/usr/lib/python2.5/BaseHTTPServer.py", line 316, in handle
    self.handle_one_request()
  File "/usr/lib/python2.5/BaseHTTPServer.py", line 310, in handle_one_request
    method()
  File "/usr/lib/pymodules/python2.5/mercurial/hgweb/server.py", line 76, in
do_GET
    self.do_POST()
  File "/usr/lib/pymodules/python2.5/mercurial/hgweb/server.py", line 67, in
do_POST
    self.do_write()
  File "/usr/lib/pymodules/python2.5/mercurial/hgweb/server.py", line 60, in
do_write
    self.do_hgweb()
  File "/usr/lib/pymodules/python2.5/mercurial/hgweb/server.py", line 124, in
do_hgweb
    for chunk in self.server.application(env, self._start_response):
  File "/usr/lib/pymodules/python2.5/mercurial/hgweb/hgweb_mod.py", line 81, in
__call__
    return self.run_wsgi(req)
  File "/usr/lib/pymodules/python2.5/mercurial/hgweb/hgweb_mod.py", line 113, in
run_wsgi
    raise ErrorResponse(HTTP_NOT_FOUND)
ErrorResponse
----------------------------------------

[ced, 2010-08-17 22:18:24]

On 2010/08/17 21:43:58, bch wrote:
> Everything seems to work ok when I use it in local or through ssh, except that
> output are not colored (IE 'hg st' gives colored output, 'hg nst' does not).

Because color extension doesn't yet manage nested.

> When I try to nclone via http (after an hg serve in the source repo) the top
> level repo is cloned but when accessing the first child repo the server output
a
> stack trace that seems to be a 404.

It is normal because "hg server" serve only one repository. You must use
webdir-config

[yangoon1, 2010-08-22 18:03:16]

http://codereview.appspot.com/1999041/diff/5003/29005
File README (right):

http://codereview.appspot.com/1999041/diff/5003/29005#newcode13
README:13: .. _vatnumber website: http://code.google.com/p/hgnested/
_hgnested website