Issue 1991043: markup documentation improvements. Not yet finished, but the base for a different Rietveld review.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1991043: markup documentation improvements. Not yet finished, but the base for a different Rietveld review. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 6 months ago by dak

Modified:
14 years, 11 months ago

Reviewers:
carl.d.sorensen, Reinhold

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

markup documentation improvements. Not yet finished, but the base for a different Rietveld review.

Patch Set 1 #

Total comments: 2

Created: 15 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -35 lines)			Patch
	M	Documentation/extending/programming-interface.itely	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	scm/markup.scm	View		5 chunks	+41 lines, -33 lines	2 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Reinhold

15 years, 6 months ago (2010-08-16 08:21:50 UTC) #2

http://codereview.appspot.com/1991043/diff/1/3
File scm/markup.scm (right):

http://codereview.appspot.com/1991043/diff/1/3#newcode134
scm/markup.scm:134: (filter pair? properties))
Mixing tab indentation with space indentation (the let is indented with
spaces...)

http://codereview.appspot.com/1991043/diff/1/3#newcode198
scm/markup.scm:198: (filter pair? properties))
Again, tab/space indentation mixed...

Expand All Messages | Collapse All Messages