Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(21)

Issue 1985042: code review 1985042: template: retain leading space if the line is not an action. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 7 months ago by r
Modified:
14 years, 7 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

template: retain leading space if the line is not an action.

Patch Set 1 #

Patch Set 2 : code review 1985042: template: retain leading space if the line is not an action. #

Patch Set 3 : code review 1985042: template: retain leading space if the line is not an action. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M src/pkg/template/template.go View 2 chunks +4 lines, -3 lines 0 comments Download
M src/pkg/template/template_test.go View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7
r
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 7 months ago (2010-08-15 05:59:40 UTC) #1
rsc1
looks good but add a test?
14 years, 7 months ago (2010-08-16 15:42:09 UTC) #2
r
PTAL it was already half-tested
14 years, 7 months ago (2010-08-16 22:54:31 UTC) #3
rsc1
still no test; add file to CL?
14 years, 7 months ago (2010-08-16 23:08:53 UTC) #4
r
sigh. PTAL.
14 years, 7 months ago (2010-08-16 23:10:51 UTC) #5
rsc1
LGTM
14 years, 7 months ago (2010-08-16 23:41:12 UTC) #6
r
14 years, 7 months ago (2010-08-16 23:44:34 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=57355a56d9ff ***

template: retain leading space if the line is not an action.

R=rsc
CC=golang-dev
http://codereview.appspot.com/1985042
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b