Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2176)

Issue 198460043: ticket:11467: Define the 'r' pattern char and the RELATED_YEAR field. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by roubert (google)
Modified:
9 years, 11 months ago
Reviewers:
pedberg, markus.icu
Base URL:
svn+ssh://source.icu-project.org/repos/icu/icu4j/trunk
Visibility:
Public.

Description

ticket:11467: Define the 'r' pattern char and the RELATED_YEAR field. For compatibility with ICU4C, the RELATED_YEAR field should be defined as the field preceding the TIME_SEPARATOR field but by mistake support for the TIME_SEPARATOR field has already been implemented in ICU4J without first defining the RELATED_YEAR field. This change therefore reorders the existing TIME_SEPARATOR field and adds definitions (without any underlying implementation) for the 'r' pattern char and the RELATED_YEAR field. R=markus.icu@gmail.com,pedberg@apple.com Committed: http://bugs.icu-project.org/trac/changeset/37032

Patch Set 1 #

Patch Set 2 : Code review: Added missing @internal annotation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -24 lines) Patch
M main/classes/core/src/com/ibm/icu/text/DateFormat.java View 1 4 chunks +21 lines, -3 lines 0 comments Download
M main/classes/core/src/com/ibm/icu/text/DateFormatSymbols.java View 2 chunks +3 lines, -3 lines 0 comments Download
M main/classes/core/src/com/ibm/icu/text/SimpleDateFormat.java View 9 chunks +10 lines, -7 lines 0 comments Download
M main/classes/core/src/com/ibm/icu/util/Calendar.java View 6 chunks +20 lines, -3 lines 0 comments Download
M main/classes/core/src/com/ibm/icu/util/GregorianCalendar.java View 2 chunks +2 lines, -1 line 0 comments Download
M main/tests/core/src/com/ibm/icu/dev/test/format/DateFormatTest.java View 5 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 5
roubert (google)
9 years, 11 months ago (2015-02-12 18:15:03 UTC) #1
roubert (google)
On Thu, Feb 12, 2015 at 8:25 PM, Peter Edberg <pedberg@apple.com> wrote: > This seems ...
9 years, 11 months ago (2015-02-13 09:43:22 UTC) #2
markus.icu
This looks fine (I don't really know this code), but please submit this under 11467 ...
9 years, 11 months ago (2015-02-13 17:33:27 UTC) #3
roubert (google)
On 2015/02/13 17:33:27, markus.icu wrote: > This looks fine (I don't really know this code), ...
9 years, 11 months ago (2015-02-13 18:19:32 UTC) #4
roubert (google)
9 years, 11 months ago (2015-02-13 18:20:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 37032 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b