Refactor tryton client

[yangoon1, 2010-02-04 12:19:20]

Thanks!

I am testing the patch, review perhaps later because I am short of time.

[yangoon1, 2010-02-06 01:10:30]

private marker: to be continued after window/view_form/screen/screen.py

http://codereview.appspot.com/198094/diff/2002/2007
File tryton/gui/window/view_form/model/field.py (right):

http://codereview.appspot.com/198094/diff/2002/2007#newcode431
tryton/gui/window/view_form/model/field.py:431: fields_name = []
field_names

http://codereview.appspot.com/198094/diff/2002/2007#newcode473
tryton/gui/window/view_form/model/field.py:473: fields_name = []
dto

[yangoon1, 2010-02-07 02:38:22]

Mega-Changeset!

1)
There is a left relation to Dialog in /tryton/gui/window/win_search.py", line
102

2)
Removing a record from m2m with Del Key causes a beep each time.

3)
Pressing Cancel on a new record of an *empty* o2m (like events on todos) leaves
an empty record instead of none, which has to be deleted prior to saving the
form.


((
JFTR but couldn't reproduce this (probably pyc files not updated?):
When pressing Edit on an *empty* o2m (like events on todos) a new record opens.

Those widgets
- don't have a Cancel button like when they are opened with New record.
- don't react on Esc to close the window.
))

Client was a bit slow on my laptop, but will test this also on my workstation.

[ced, 2010-02-07 21:33:38]

On 2010/02/07 02:38:22, yangoon wrote:
> Mega-Changeset!
> 
> 1)
> There is a left relation to Dialog in /tryton/gui/window/win_search.py", line
> 102

Fixed.

> 
> 2)
> Removing a record from m2m with Del Key causes a beep each time.

What is the beep?

> 
> 3)
> Pressing Cancel on a new record of an *empty* o2m (like events on todos)
leaves
> an empty record instead of none, which has to be deleted prior to saving the
> form.

Could not reproduce. There is no events on todos.

> 
> 
> ((
> JFTR but couldn't reproduce this (probably pyc files not updated?):
> When pressing Edit on an *empty* o2m (like events on todos) a new record
opens.
> 
> Those widgets
> - don't have a Cancel button like when they are opened with New record.

This is normal for editing.

> - don't react on Esc to close the window.

If the form is not valid this is normal.

> ))
> 
> Client was a bit slow on my laptop, but will test this also on my workstation.

Could you be more precise on what is slow?

[yangoon1, 2010-02-08 00:10:37]

On 2010/02/07 21:33:38, ced wrote:

> > 2)
> > Removing a record from m2m with Del Key causes a beep each time.
> 
> What is the beep?

Normal system beep, like error on console.

> > 3)
> > Pressing Cancel on a new record of an *empty* o2m (like events on todos)
> leaves
> > an empty record instead of none, which has to be deleted prior to saving the
> > form.
> 
> Could not reproduce. There is no events on todos.

Sorry, speaking of occurences.

Can reproduce like this:
1) New Exception Date on Todo
2) Close immediately with Esc
-> empty new record remaining

3) On saving Todo:
Error: The field "Date" on "Recurrence Date" is required.

which is normal, but (this is another issue) message should be:
The field "Date" on "Exception Date" is required.

> Could you be more precise on what is slow?

Switching from list to form view on party is quite unresponsive, but especially
opening new record on party takes 2-3 sec.

[ced, 2010-02-08 10:29:27]

On 2010/02/08 00:10:37, yangoon wrote:
> On 2010/02/07 21:33:38, ced wrote:
> 
> > > 2)
> > > Removing a record from m2m with Del Key causes a beep each time.
> > 
> > What is the beep?
> 
> Normal system beep, like error on console.

How can I reproduce that?

> 3) On saving Todo:
> Error: The field "Date" on "Recurrence Date" is required.
> 
> which is normal, but (this is another issue) message should be:
> The field "Date" on "Exception Date" is required.

Please fill an issue.

> 
> > Could you be more precise on what is slow?
> 
> Switching from list to form view on party is quite unresponsive, but
especially
> opening new record on party takes 2-3 sec.

Did you compare with and without patch?

[yangoon1, 2010-02-08 12:08:38]

On 2010/02/08 10:29:27, ced wrote:
> On 2010/02/08 00:10:37, yangoon wrote:
> > On 2010/02/07 21:33:38, ced wrote:
> > 
> > > > 2)
> > > > Removing a record from m2m with Del Key causes a beep each time.
> > > 
> > > What is the beep?
> > 
> > Normal system beep, like error on console.
> 
> How can I reproduce that?

Probably not at all;)
It is only on my laptop, not on my workstation. Will test further this evening.

> > 3) On saving Todo:
> > Error: The field "Date" on "Recurrence Date" is required.
> > 
> > which is normal, but (this is another issue) message should be:
> > The field "Date" on "Exception Date" is required.
> 
> Please fill an issue.

Done.

> > > Could you be more precise on what is slow?
> > 
> > Switching from list to form view on party is quite unresponsive, but
> especially
> > opening new record on party takes 2-3 sec.

Also on my workstation it takes 1-2 sec.
 
> Did you compare with and without patch?

Not yet.

[yangoon1, 2010-02-08 12:11:55]

On 2010/02/08 00:10:37, yangoon wrote:
> On 2010/02/07 21:33:38, ced wrote:

> > > 3)
> > > Pressing Cancel on a new record of an *empty* o2m (like events on todos)
> > leaves
> > > an empty record instead of none, which has to be deleted prior to saving
the
> > > form.
> > 
> > Could not reproduce. There is no events on todos.
> 
> Sorry, speaking of occurences.
> 
> Can reproduce like this:
> 1) New Exception Date on Todo
> 2) Close immediately with Esc
> -> empty new record remaining

Cannot any more reproduce like above, but like this:
Change from list view to form view on empty o2m (like Exception Date) and
immediately back leaves empty record.

[ced, 2010-02-08 12:14:50]

On 2010/02/08 12:11:55, yangoon wrote:
> On 2010/02/08 00:10:37, yangoon wrote:
> > On 2010/02/07 21:33:38, ced wrote:
> 
> > > > 3)
> > > > Pressing Cancel on a new record of an *empty* o2m (like events on todos)
> > > leaves
> > > > an empty record instead of none, which has to be deleted prior to saving
> the
> > > > form.
> > > 
> > > Could not reproduce. There is no events on todos.
> > 
> > Sorry, speaking of occurences.
> > 
> > Can reproduce like this:
> > 1) New Exception Date on Todo
> > 2) Close immediately with Esc
> > -> empty new record remaining
> 
> Cannot any more reproduce like above, but like this:
> Change from list view to form view on empty o2m (like Exception Date) and
> immediately back leaves empty record.

That is the previous (normal) behavior

[yangoon1, 2010-02-09 00:07:47]

On 2010/02/08 10:29:27, ced wrote:

> Did you compare with and without patch?

Comparing directly leaves indeed the impression, that the client with the patch
is faster.

Nevertheless one issue with the patch:
1) Open list view of party
2) Ctl + N 
3) Ctl + L
4) Don't save new record

-> jumps to last record of list with patch
-> remains on current record without patch

[yangoon1, 2010-02-09 00:10:56]

On 2010/02/08 10:29:27, ced wrote:
> On 2010/02/08 00:10:37, yangoon wrote:
> > On 2010/02/07 21:33:38, ced wrote:
> > 
> > > > 2)
> > > > Removing a record from m2m with Del Key causes a beep each time.
> > > 
> > > What is the beep?
> > 
> > Normal system beep, like error on console.
> 
> How can I reproduce that?

It is an issue on my notebook, existing with or without patch.

[yangoon1, 2010-02-09 00:16:04]

On 2010/02/08 12:14:50, ced wrote:

> That is the previous (normal) behavior

True. Issue on roundup created.

[ced, 2010-02-09 09:07:21]

On 2010/02/09 00:07:47, yangoon wrote:
> On 2010/02/08 10:29:27, ced wrote:
> 
> > Did you compare with and without patch?
> 
> Comparing directly leaves indeed the impression, that the client with the
patch
> is faster.
> 
> Nevertheless one issue with the patch:
> 1) Open list view of party
> 2) Ctl + N 
> 3) Ctl + L
> 4) Don't save new record
> 
> -> jumps to last record of list with patch
> -> remains on current record without patch

For me, it is logical because you create a new record that is appended at the
end of the list. By not saving it, you remove it so the cursor will focus on the
upper one which is now the last one.

[yangoon1, 2010-02-09 10:54:55]

On 2010/02/09 09:07:21, ced wrote:
> On 2010/02/09 00:07:47, yangoon wrote:
> > On 2010/02/08 10:29:27, ced wrote:
> > 
> > > Did you compare with and without patch?
> > 
> > Comparing directly leaves indeed the impression, that the client with the
> patch
> > is faster.
> > 
> > Nevertheless one issue with the patch:
> > 1) Open list view of party
> > 2) Ctl + N 
> > 3) Ctl + L
> > 4) Don't save new record
> > 
> > -> jumps to last record of list with patch
> > -> remains on current record without patch
> 
> For me, it is logical because you create a new record that is appended at the
> end of the list. By not saving it, you remove it so the cursor will focus on
the
> upper one which is now the last one.

When cancelling an action you expect to be at the same place than before,
because you didn't (want to) change anything. To find the application in the
same state than before the action gives also feedback to the user, that indeed
nothing was changed.

Ack for new saved record: there you want to be of course on the newly created
record.