Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(866)

Issue 198076: Review: broken string ops (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by larrygritz
Modified:
13 years ago
Reviewers:
ckulla
CC:
osl-dev_googlegroups.com, dev-osl_imageworks.com
Base URL:
http://openshadinglanguage.googlecode.com/svn/trunk/
Visibility:
Public.

Description

In several string ops, I used a local var that just told whether any of the arguments were varying, to determine whether to assign to just the first element of Result, or all of them. I should really have been checking whether Result itself was varying. They could differ because the adjust_varying(Result) will make it varying even if none of the args are varying, if the instruction is itself inside a varying conditional.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
src/liboslexec/opstring.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3
larrygritz
13 years ago (2010-02-03 00:49:56 UTC) #1
ckulla
LGTM! You might want to hunt for this pattern in a few other places. get/setmessage ...
13 years ago (2010-02-03 00:51:49 UTC) #2
larrygritz
13 years ago (2010-02-03 01:22:25 UTC) #3
I'm going to commit this ASAP and then hunt for other possible occurrences.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b