Issue 198076: Review: broken string ops

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 198076: Review: broken string ops (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by larrygritz

Modified:
14 years, 2 months ago

Reviewers:
ckulla

CC:
osl-dev_googlegroups.com, dev-osl_imageworks.com

Base URL:
http://openshadinglanguage.googlecode.com/svn/trunk/

Visibility:
Public.

Description

In several string ops, I used a local var that just told whether any of the arguments were varying, to determine whether to assign to just the first element of Result, or all of them. I should really have been checking whether Result itself was varying. They could differ because the adjust_varying(Result) will make it varying even if none of the args are varying, if the instruction is itself inside a varying conditional.

Patch Set 1 #

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
		src/liboslexec/opstring.cpp	View		4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ckulla

LGTM! You might want to hunt for this pattern in a few other places. get/setmessage ...

14 years, 2 months ago (2010-02-03 00:51:49 UTC) #2

larrygritz

14 years, 2 months ago (2010-02-03 01:22:25 UTC) #3

I'm going to commit this ASAP and then hunt for other possible occurrences.

Expand All Messages | Collapse All Messages