code review 198074: added note about the GOARM env variable

added note about the GOARM env variable

[kaib, 2010-02-02 23:20:38]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[r, 2010-02-02 23:54:21]

http://codereview.appspot.com/198074/diff/3/4
File doc/install.html (right):

http://codereview.appspot.com/198074/diff/3/4#newcode95
doc/install.html:95: ARMv6 has more efficient synchronization primitives which
aren't supported
s/which/that/
or even get rid of the clause altogether; the first part of the sentence already
says it.

http://codereview.appspot.com/198074/diff/3/4#newcode96
doc/install.html:96: by earlier versions. Setting this environment variable to 5
will compile the
s/this environment variable/<code>$GOARM</code>/

http://codereview.appspot.com/198074/diff/3/4#newcode97
doc/install.html:97: runtime libraries using just SWP instructions which works
on older architectures.
s/which works/that work/
s/.$/as well./

http://codereview.appspot.com/198074/diff/3/4#newcode98
doc/install.html:98: If you try to run v6 code on a pre v6 core you will get an
illegal instruction.
Running v6 code on an older core will cause an illegal instruction trap.

[kaib, 2010-02-03 00:08:23]

ptal

On Tue, Feb 2, 2010 at 3:54 PM,  <r@golang.org> wrote:
>
> http://codereview.appspot.com/198074/diff/3/4
> File doc/install.html (right):
>
> http://codereview.appspot.com/198074/diff/3/4#newcode95
> doc/install.html:95: ARMv6 has more efficient synchronization primitives
> which aren't supported
> s/which/that/
> or even get rid of the clause altogether; the first part of the sentence
> already says it.
>
> http://codereview.appspot.com/198074/diff/3/4#newcode96
> doc/install.html:96: by earlier versions. Setting this environment
> variable to 5 will compile the
> s/this environment variable/<code>$GOARM</code>/
>
> http://codereview.appspot.com/198074/diff/3/4#newcode97
> doc/install.html:97: runtime libraries using just SWP instructions which
> works on older architectures.
> s/which works/that work/
> s/.$/as well./
>
> http://codereview.appspot.com/198074/diff/3/4#newcode98
> doc/install.html:98: If you try to run v6 code on a pre v6 core you will
> get an illegal instruction.
> Running v6 code on an older core will cause an illegal instruction trap.
>
> http://codereview.appspot.com/198074/show
>

[r, 2010-02-03 00:30:56]

LGTM

[kaib, 2010-02-03 02:09:12]

*** Submitted as http://code.google.com/p/go/source/detail?r=3e3b3f13a7af ***

added note about the GOARM env variable

R=rsc, r
CC=golang-dev
http://codereview.appspot.com/198074