Issue 198057: code review 198057: gc: bug246

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 198057: code review 198057: gc: bug246 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by rsc

Modified:
14 years, 2 months ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

Description

gc: bug246

Patch Set 1 #

Patch Set 2 : code review 198057: gc: bug246 #

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -11 lines)			Patch
M	src/cmd/gc/align.c	View	3 chunks	+5 lines, -0 lines	0 comments	Download
M	src/cmd/gc/const.c	View	4 chunks	+10 lines, -1 line	0 comments	Download
M	src/cmd/gc/go.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/gc/walk.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/fixedbugs/bug246.go	View	2 chunks	+8 lines, -4 lines	0 comments	Download
M	test/golden.out	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 2 months ago (2010-02-02 07:05:13 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=55fc047b9a30 *** gc: bug246 R=ken2 CC=golang-dev http://codereview.appspot.com/198057

14 years, 2 months ago (2010-02-02 07:05:18 UTC) #2

ken3

14 years, 2 months ago (2010-02-02 09:31:20 UTC) #3

LGTM

On 2010/02/02 07:05:18, rsc wrote:
> *** Submitted as http://code.google.com/p/go/source/detail?r=55fc047b9a30 ***
> 
> gc: bug246
> 
> R=ken2
> CC=golang-dev
> http://codereview.appspot.com/198057

Expand All Messages | Collapse All Messages