code review 198044: Avoid overflow of include and define buffers in 5a/6a/8...

Avoid overflow of include and define buffers in 5a/6a/8a/5c/6c/8c

[dpx, 2010-02-01 22:54:54]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc, 2010-02-04 07:29:26]

These aren't things that will get too big, but
reallocating on every single append is still a bit
inefficient.  An easy way to cut the allocs down
without introducing more variables is to realloc
every few additions, like 8:

if(n%8 == 0)
    x = realloc(x, (n+8)*sizeof x[0])
x[n++] = newentry

[dpx, 2010-02-05 00:21:55]

Hello rsc (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2010-02-05 00:34:09]

It can be even simpler: drop NALLOC completely,
don't bother initializing the globals, and do the
realloc before appending to the list.  There's no
need for a shared constant if the only lines that
need to be in sync are right next to each other.

Russ

[dpx, 2010-02-05 02:11:31]

Hello rsc (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2010-02-05 09:22:35]

LGTM

thanks

[rsc, 2010-02-05 09:41:00]

*** Submitted as http://code.google.com/p/go/source/detail?r=10111138461e ***

5a/6a/8a/5c/6c/8c: remove fixed-size arrays for -I and -D options

R=rsc
CC=golang-dev
http://codereview.appspot.com/198044

Committer: Russ Cox <rsc@golang.org>