Issue 1980049: Update for new Transaction and Cache

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1980049: Update for new Transaction and Cache (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 5 months ago by ced

Modified:
15 years, 5 months ago

Reviewers:
bch, yangoon1

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: 15 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -27 lines)			Patch
M	proteus/__init__.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	proteus/config.py	View	4 chunks	+26 lines, -24 lines	2 comments	Download
M	proteus/tests/test_model.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

yangoon1

Looks ok so far for me. It would be easier to review two different changesets ...

15 years, 5 months ago (2010-08-25 10:47:27 UTC) #2

ced

15 years, 5 months ago (2010-08-25 11:25:52 UTC) #3

http://codereview.appspot.com/1980049/diff/1/3
File proteus/config.py (right):

http://codereview.appspot.com/1980049/diff/1/3#newcode53
proteus/config.py:53: with Transaction().start(self._config.database_name,
On 2010/08/25 10:47:28, yangoon wrote:
> Originally it was self._config.database.database_name and I couldn't detect
the
> change to require instead self._config.database_name. Probably I am mislead,
> could you give a hint?

There is no more database on config

Expand All Messages | Collapse All Messages