Fix Mac OS X application termination and fully integrate menubar

[ced, 2010-08-25 05:55:37]

http://codereview.appspot.com/1975047/diff/1/4
File tryton/gui/main.py (right):

http://codereview.appspot.com/1975047/diff/1/4#newcode32
tryton/gui/main.py:32: import gtk_osxapplication
From where did this module comes?

http://codereview.appspot.com/1975047/diff/1/4#newcode202
tryton/gui/main.py:202: menuitem_file.show_all()
Why those show_all ?
menubar.show_all() is called belong.

[pheller, 2010-08-25 06:03:29]

http://codereview.appspot.com/1975047/diff/1/4
File tryton/gui/main.py (right):

http://codereview.appspot.com/1975047/diff/1/4#newcode32
tryton/gui/main.py:32: import gtk_osxapplication
On 2010/08/25 05:55:37, ced wrote:
> From where did this module comes?

This is a new implementation within gtk-osx.  You can see them both in the
source tree here:  

http://gtk-osx.git.sourceforge.net/git/gitweb.cgi?p=gtk-osx/ige-mac-integrati...

Using gtk_osxapplication is a good idea, because it removes the dependency on
the Apple "Carbon" framework, which will probably be deprecated in the next
major revision of Mac OS.

http://codereview.appspot.com/1975047/diff/1/4#newcode202
tryton/gui/main.py:202: menuitem_file.show_all()
On 2010/08/25 05:55:37, ced wrote:
> Why those show_all ?
> menubar.show_all() is called belong.

Line 189 disables "show_all" for the menubar -- this is because
menubar.showall() would be followed by menubar.hide() on the Mac -- and in
testing, this increased application load time and actually made the menu bar
blink.

The individual menus need to have show_all() called so that they they can be
bound to the Mac menubar.

[ced, 2010-08-25 07:15:39]

http://codereview.appspot.com/1975047/diff/1/4
File tryton/gui/main.py (right):

http://codereview.appspot.com/1975047/diff/1/4#newcode32
tryton/gui/main.py:32: import gtk_osxapplication
On 2010/08/25 06:03:29, pheller wrote:
> On 2010/08/25 05:55:37, ced wrote:
> > From where did this module comes?
> 
> This is a new implementation within gtk-osx.  You can see them both in the
> source tree here:  
> 
>
http://gtk-osx.git.sourceforge.net/git/gitweb.cgi?p=gtk-osx/ige-mac-integrati...
> 
> Using gtk_osxapplication is a good idea, because it removes the dependency on
> the Apple "Carbon" framework, which will probably be deprecated in the next
> major revision of Mac OS.

Perhaps we could keep igemacintegration as fallback

http://codereview.appspot.com/1975047/diff/1/4#newcode202
tryton/gui/main.py:202: menuitem_file.show_all()
On 2010/08/25 06:03:29, pheller wrote:
> On 2010/08/25 05:55:37, ced wrote:
> > Why those show_all ?
> > menubar.show_all() is called belong.
> 
> Line 189 disables "show_all" for the menubar -- this is because
> menubar.showall() would be followed by menubar.hide() on the Mac -- and in
> testing, this increased application load time and actually made the menu bar
> blink.
> 
> The individual menus need to have show_all() called so that they they can be
> bound to the Mac menubar.

I think the code is not clear about that.
Could you put all the show_all together and don't call show_all on menubar when
macapp.

[ced, 2010-10-04 20:37:33]

http://codereview.appspot.com/1975047/diff/1/tryton/gui/main.py
File tryton/gui/main.py (right):

http://codereview.appspot.com/1975047/diff/1/tryton/gui/main.py#newcode1300
tryton/gui/main.py:1300: if gtk.main_level() > 0:
Why this?

http://codereview.appspot.com/1975047/diff/1/tryton/gui/main.py#newcode1309
tryton/gui/main.py:1309: if self.macapp is not None:
Why?

[pheller, 2010-10-06 01:47:18]

To answer some past questions:

I think there is no need to maintain a fallback from gtk_osxapplication
(igemacintegration), because most people will download the binary client. 
Anyone who wants to build it can use the development environment instructions
from the tryton wiki.

I have gathered the show_all() commands for each menu item together, and only
show_all() on menubar if not a Mac App.

The reason to test for gtk.main_level > 0 in sig_quit is because sig_quit can be
called from outside the main_loop on the Mac; specifically, because sig_login is
called before we enter the main loop - and the Menubar is handled by the gtk-osx
NSApplication mainloop.  This prevents the RuntimeError "called outside
mainloop".  Alternatively, could put gtk.main_quit into try/except.

-------

Known issues with Mac client:

Quit from dock icon causes client to segfault.  Not entirely sure why.  The
gtk-osx guy has tried to isolate the problem too, without success.

The menu accelerators are still the "ctrl" style; they should be "cmd" on Mac
(gtk.gdk.META_MASK), but gdk discards ALT_MASK, which is what gtk-osx should
remap the gtk.button accelerators to.  So, they must stay the same for now.

_______

Other things fixed here:

"tryton" -> "Tryton" in the menu bar of the Application

Removed the quotes around the volume name in the dmg built by setup.py.  They
aren't needed.

[ced, 2010-10-06 07:42:33]

On 2010/10/06 01:47:18, pheller wrote:
> Other things fixed here:
> 
> "tryton" -> "Tryton" in the menu bar of the Application

No tryton is the right name.

> Removed the quotes around the volume name in the dmg built by setup.py.  They
> aren't needed.

It seems to be done.

[ced, 2010-10-06 07:42:41]

http://codereview.appspot.com/1975047/diff/8001/CHANGELOG
File CHANGELOG (right):

http://codereview.appspot.com/1975047/diff/8001/CHANGELOG#newcode1
CHANGELOG:1: * More fully integrate GTK menubar with Mac OS
for Mac OS

http://codereview.appspot.com/1975047/diff/8001/setup.py
File setup.py (right):

http://codereview.appspot.com/1975047/diff/8001/setup.py#newcode74
setup.py:74: 'CFBundleName': 'Tryton',
The name of the client is tryton not Tryton.

http://codereview.appspot.com/1975047/diff/8001/tryton/gui/main.py
File tryton/gui/main.py (right):

http://codereview.appspot.com/1975047/diff/8001/tryton/gui/main.py#newcode177
tryton/gui/main.py:177: 
Ending space

http://codereview.appspot.com/1975047/diff/8001/tryton/gui/main.py#newcode181
tryton/gui/main.py:181: 
Ending space

http://codereview.appspot.com/1975047/diff/8001/tryton/gui/main.py#newcode1310
tryton/gui/main.py:1310: #            if self.macapp is not None:
Remove comment

[ced, 2010-10-06 12:21:06]

So it is ok for me

[pheller, 2010-10-14 19:12:44]

Added back in cfBundleName for GUI Application Presentation