Issue 1973047: fix es53.js JSON.parse for IE8

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1973047: fix es53.js JSON.parse for IE8 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 7 months ago by felix8a

Modified:
15 years, 7 months ago

Reviewers:
MikeSamuel

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

JSON.parse does endsWith__(s) instead of endsWith__.test(s). this was fixed in cajita.js http://codereview.appspot.com/987045 this change fixes it in es53.js too.

Patch Set 1 #

Created: 15 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/com/google/caja/es53.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

MikeSamuel

15 years, 7 months ago (2010-08-24 15:20:25 UTC) #2

LGTM

2010/8/24  <felix8a@gmail.com>:
> Reviewers: MikeSamuel,
>
> Description:
> JSON.parse does endsWith__(s) instead of endsWith__.test(s).
> this was fixed in cajita.js
> http://codereview.appspot.com/987045
>
> this change fixes it in es53.js too.
>
> Please review this at http://codereview.appspot.com/1973047/
>
> Affected files:
>  M     src/com/google/caja/es53.js
>
>
> Index: src/com/google/caja/es53.js
> ===================================================================
> --- src/com/google/caja/es53.js (revision 4251)
> +++ src/com/google/caja/es53.js (working copy)
> @@ -971,7 +971,7 @@
>             json_sans_eval.checkSyntax(text, function (key) {
>               return key !== 'valueOf' &&
>                   key !== 'toString' &&
> -                  !endsWith__(key);
> +                  !endsWith__.test(key);
>             }), reviver);
>       }),
>       stringify: markFunc(function (obj, opt_replacer, opt_space) {
>
>
>

Expand All Messages | Collapse All Messages