src/cmd/gc/subr.c - Issue 197044: code review 197044: gc: ... T corner cases

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/cmd/gc/subr.c

Issue 197044: code review 197044: gc: ... T corner cases (Closed)

Patch Set: code review 197044: gc: ... T corner cases Created 15 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/cmd/gc/subr.c

===================================================================

--- a/src/cmd/gc/subr.c

+++ b/src/cmd/gc/subr.c

@@ -1004,6 +1004,9 @@

if(n->dodata != 0)

fmtprint(fp, " dd(%d)", n->dodata);

+ if(n->isddd != 0)

+ fmtprint(fp, " isddd(%d)", n->isddd);

return 0;

}

@@ -2585,6 +2588,9 @@

t = n->left->type;

if(t == T)

goto ret;

+ if(n->left->op == OTYPE)

+ goto ret;

if(n->right->op != ONAME)

goto ret;

@@ -2783,6 +2789,9 @@

n = newname(lookup(buf));

}

a = nod(ODCLFIELD, n, typenod(t->type));

+ a->isddd = t->isddd;

+ if(n != N)

+ n->isddd = t->isddd;

args = list(args, a);

}

return args;

« no previous file with comments | « src/cmd/gc/reflect.c ('k') | src/cmd/gc/typecheck.c » ('j') | no next file with comments »