Move _notify_issue to notify.py

Move _notify_issue to notify.py

R=maruel@chromium.org
BUG=

[iannucci, 2013-10-30 04:53:44]

PTAL, pretty straightforward.

[M-A, 2013-10-30 13:04:21]

I'm not sure it's a good axis of separation though. I'd prefer a functional
separation across the line of admin vs issue vs patch management. This side
support may be split in a separate mix-bag file but notify by itself is probably
not worth its own file.

That said, I don't mind much, but I don't think this helps maintainability. Also
the file name is a bit unclear, something like xmpp_notify.py would be *much*
clearer.

https://codereview.appspot.com/19700043/diff/1/codereview/notify.py
File codereview/notify.py (right):

https://codereview.appspot.com/19700043/diff/1/codereview/notify.py#newcode22
codereview/notify.py:22: 
2 lines

https://codereview.appspot.com/19700043/diff/1/codereview/notify.py#newcode80
codereview/notify.py:80: 
lines

[iannucci, 2013-10-30 23:26:55]

PTAL. Moved all XMPP stuff into the same file now.

Will do the same for mail notifications too.

More functional separation of views to come.

[iannucci, 2013-10-30 23:27:15]

On 2013/10/30 23:26:55, iannucci wrote:
> PTAL. Moved all XMPP stuff into the same file now.
> 
> Will do the same for mail notifications too.

(mail changes in separate CL)

> 
> More functional separation of views to come.

[iannucci, 2013-11-01 23:00:44]

Any feedback on this?

[M-A, 2013-11-01 23:04:10]

lgtm

https://codereview.appspot.com/19700043/diff/20001/codereview/notify_xmpp.py
File codereview/notify_xmpp.py (right):

https://codereview.appspot.com/19700043/diff/20001/codereview/notify_xmpp.py#...
codereview/notify_xmpp.py:30: except Exception, err:
except Exception as err:

(while at it)

[iannucci, 2013-11-01 23:21:25]

https://codereview.appspot.com/19700043/diff/20001/codereview/notify_xmpp.py
File codereview/notify_xmpp.py (right):

https://codereview.appspot.com/19700043/diff/20001/codereview/notify_xmpp.py#...
codereview/notify_xmpp.py:30: except Exception, err:
On 2013/11/01 23:04:10, M-A wrote:
> except Exception as err:
> 
> (while at it)

Done :)

[iannucci, 2013-11-01 23:55:19]

Commited
https://code.google.com/p/rietveld/source/detail?r=61ffe4c50c3c77ff6e2fed975a...
Merged
https://code.google.com/p/rietveld/source/detail?r=e02bd5025086a13e2950a84a9c...