Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4)

Issue 1969041: Change MakeRequestHandler method protected instead of package private

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 7 months ago by zhoresh
Modified:
15 years, 7 months ago
Reviewers:
johnfargo, dev-remailer
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk
Visibility:
Public.

Description

Previously those functions were protected in ProxyBase and we were using them when overriding MakeRequestHandler

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java View 5 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 2
zhoresh
15 years, 7 months ago (2010-08-11 00:37:46 UTC) #1
johnfargo
15 years, 7 months ago (2010-08-11 00:42:34 UTC) #2
LGTM++
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b