Issue 19690043: Move decorators and responses to their own files (chromium).

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 19690043: Move decorators and responses to their own files (chromium). (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by iannucci

Modified:
11 years, 10 months ago

Reviewers:
M-A

CC:
codereview-list_googlegroups.com

Base URL:
hg::https://iannucci%40chromium.org@code.google.com/p/rietveld/@git_stuff_down

Visibility:
Public.

More Reviews

Description

Move decorators and responses to their own files. Chromium counterpart to https://codereview.appspot.com/17910043/ I also took the liberty of adding a decorators_chromium.py Conflicts: codereview/views.py R=maruel@chromium.org BUG=

Patch Set 1 #

Total comments: 5

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+677 lines, -612 lines)			Patch
A +	codereview/common.py	View	1 chunk	+2 lines, -8 lines	0 comments	Download
A	codereview/decorators.py	View	1 chunk	+356 lines, -0 lines	1 comment	Download
A	codereview/decorators_chromium.py	View	1 chunk	+77 lines, -0 lines	2 comments	Download
A	codereview/responses.py	View	1 chunk	+91 lines, -0 lines	2 comments	Download
M	codereview/views.py	View	67 chunks	+126 lines, -524 lines	0 comments	Download
M	codereview/views_chromium.py	View	14 chunks	+25 lines, -80 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

iannucci

PTAL assuming https://codereview.appspot.com/17910043/ lgty https://codereview.appspot.com/19690043/diff/1/codereview/decorators.py File codereview/decorators.py (right): https://codereview.appspot.com/19690043/diff/1/codereview/decorators.py#newcode97 codereview/decorators.py:97: # return HttpResponseRedirect(django_settings.MEDIA_URL + "blank.jpg") ...

11 years, 10 months ago (2013-10-30 04:51:44 UTC) #1

M-A

lgtm https://codereview.appspot.com/19690043/diff/1/codereview/decorators_chromium.py File codereview/decorators_chromium.py (right): https://codereview.appspot.com/19690043/diff/1/codereview/decorators_chromium.py#newcode28 codereview/decorators_chromium.py:28: def key_required(func): Order + 2 lines between file ...

11 years, 10 months ago (2013-10-30 13:01:19 UTC) #2

iannucci

11 years, 10 months ago (2013-10-30 23:19:52 UTC) #3

Committed w/ changes as
https://code.google.com/p/rietveld/source/detail?r=fda2d2e0e21710feafcca07773...

https://codereview.appspot.com/19690043/diff/1/codereview/decorators_chromium.py
File codereview/decorators_chromium.py (right):

https://codereview.appspot.com/19690043/diff/1/codereview/decorators_chromium...
codereview/decorators_chromium.py:28: def key_required(func):
On 2013/10/30 13:01:19, M-A wrote:
> Order + 2 lines between file level symbols

Done.

https://codereview.appspot.com/19690043/diff/1/codereview/responses.py
File codereview/responses.py (right):

https://codereview.appspot.com/19690043/diff/1/codereview/responses.py#newcode33
codereview/responses.py:33: class HttpTextResponse(HttpResponse):
On 2013/10/30 13:01:19, M-A wrote:
> In fact, other the classes by name here too.

Will do as followup

Expand All Messages | Collapse All Messages