Issue 1966043: Adding the html tag context for the ProxyUri resource (Closed)
DescriptionThis change:
1) Adds the html tag (called htmlTagContext) for which the resource is being proxied.
2) Propogates html tag context all the way to HttpRequest.
3) Rewrite html pages only if the htmlTagContext is not "script".
The motivation of this change is two fold:
1) We get more control and context about the url requested by the browser.
2) This helps us not rewrite pages which have their Content-Type header incorrectly set. For example, we recently ran into javascript pages that set Content-Type incorrectly as "text/html". We end up rewriting the content (enclose it in "<html> .. </html>") and the browser is no longer able to execute the javascript.
For example:
Original html snippet:
<script src="/gadgets/proxy?url=1.js&....>
Http Request for resource:
GET 1.js HTTP/1.0
....
Http Response:
200 OK
Content-Type: text/html
var hello = "buffalo";
....
RewriterUtils.isHtml() returns true
Final response:
200 OK
Content-Type: text/html
<html><body>var hello = "buffalo";</body></html>
= Browser unhappy :(
Hence this change. We can later add more strict control by blacklisting more tags like "img" etc., or we could whitelist only known html tags like "iframe", "link" etc. However, the current need is only to correct javascript resources with incorrect content type headers.
Patch Set 1 #Patch Set 2 : '2nd_pass' #Patch Set 3 : svn_up #Patch Set 4 : svn_up #Patch Set 5 : reverting_unnecessary_files #Patch Set 6 : copying_from_1969044 #Patch Set 7 : svn_up #Patch Set 8 : 'updating_comment' #Patch Set 9 : 'updating_comment' #Patch Set 10 : 'adding_tests' #Patch Set 11 : 'adding_tests' #Patch Set 12 : 'adding_more_tests' #Patch Set 13 : 'adding_more_tests' #
Total comments: 6
Patch Set 14 : svn_up #
Total comments: 8
Patch Set 15 : svn_up #Patch Set 16 : adding_more_instances_of_html_tag_context #Patch Set 17 : lint #
Total comments: 2
Patch Set 18 : addressing_anupamas_comment #
Total comments: 6
Patch Set 19 : addressing_anupamas_comments #Patch Set 20 : svn_up #MessagesTotal messages: 14
|
