Issue 1966042: Fix support for unsandboxed links in the cajoling service

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1966042: Fix support for unsandboxed links in the cajoling service (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 10 months ago by MikeSamuel

Modified:
15 years, 10 months ago

Reviewers:
kpreid1, Jasvir

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: 15 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+82 lines, -30 lines)			Patch
M	src/com/google/caja/service/AbstractCajolingHandler.java	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/com/google/caja/service/ContentHandler.java	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/com/google/caja/service/GadgetHandler.java	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/com/google/caja/service/HtmlHandler.java	View	2 chunks	+3 lines, -2 lines	2 comments	Download
M	src/com/google/caja/service/ImageHandler.java	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/com/google/caja/service/InnocentHandler.java	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/com/google/caja/service/JsHandler.java	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	tests/com/google/caja/service/HtmlHandlerTest.java	View	5 chunks	+74 lines, -6 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

kpreid2

http://codereview.appspot.com/1966042/diff/1/3 File src/com/google/caja/service/HtmlHandler.java (right): http://codereview.appspot.com/1966042/diff/1/3#newcode83 src/com/google/caja/service/HtmlHandler.java:83: meta.setIdClass(args.get("idclass")); Is this line actually relevant to this change?

15 years, 10 months ago (2010-08-10 22:53:49 UTC) #2

Jasvir

LGTM The sext=false kludge is a temporary workaround for the lack of a single uri ...

15 years, 10 months ago (2010-08-10 22:54:49 UTC) #3

MikeSamuel

15 years, 10 months ago (2010-08-11 04:28:21 UTC) #4

http://codereview.appspot.com/1966042/diff/1/3
File src/com/google/caja/service/HtmlHandler.java (right):

http://codereview.appspot.com/1966042/diff/1/3#newcode83
src/com/google/caja/service/HtmlHandler.java:83:
meta.setIdClass(args.get("idclass"));
On 2010/08/10 22:53:51, kpreid2 wrote:
> Is this line actually relevant to this change?

No.  It simplifies the unittests a lot.

Expand All Messages | Collapse All Messages