Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14)

Issue 1962045: Changes that were reverted in r982090 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 5 months ago by gagan.goku
Modified:
15 years, 5 months ago
Reviewers:
johnfargo, zhoresh, dev-remailer, mhermanto
CC:
cool-shindig-committers_googlegroups.com, anupama.dutta
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

Small changes that Anupama made in this patch: http://codereview.appspot.com/1855044/show which got reverted in this cl: http://codereview.appspot.com/1696056/show.

Patch Set 1 #

Patch Set 2 : updating_change #

Total comments: 2

Patch Set 3 : 'addressing_anupamas_comment' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -33 lines) Patch
M java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java View 1 2 4 chunks +13 lines, -26 lines 0 comments Download
M java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyHandlerTest.java View 1 2 4 chunks +32 lines, -7 lines 0 comments Download

Messages

Total messages: 5
anupama.dutta
Thanks, Gagan, for making these changes. One small comment towards changing the test to become ...
15 years, 5 months ago (2010-08-12 13:37:49 UTC) #1
gagan.goku
http://codereview.appspot.com/1962045/diff/2001/3001 File java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyHandlerTest.java (right): http://codereview.appspot.com/1962045/diff/2001/3001#newcode96 java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyHandlerTest.java:96: HttpRequest req = new HttpRequest(Uri.parse(url)); On 2010/08/12 13:37:49, anupama.dutta ...
15 years, 5 months ago (2010-08-12 16:39:44 UTC) #2
anupama.dutta
LGTM.
15 years, 5 months ago (2010-08-12 16:42:21 UTC) #3
johnfargo
On 2010/08/12 16:42:21, anupama.dutta wrote: > LGTM. Redone patch committed as r986806.
15 years, 5 months ago (2010-08-18 17:33:32 UTC) #4
gagan.goku
15 years, 5 months ago (2010-08-19 05:19:08 UTC) #5
On 2010/08/18 17:33:32, johnfargo wrote:
> On 2010/08/12 16:42:21, anupama.dutta wrote:
> > LGTM.
> 
> Redone patch committed as r986806.

Thanks John
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b