Issue 19620043: Expose PK11_GenerateKeyPairWithOpFlags to windows build of NSS.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 19620043: Expose PK11_GenerateKeyPairWithOpFlags to windows build of NSS. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by eroman

Modified:
11 years, 10 months ago

Reviewers:
wtc, Ryan Sleevi

CC:
padolph_netflix.com

Base URL:
https://chromium.googlesource.com/chromium/deps/nss.git@master

Visibility:
Public.

More Reviews

Description

Expose PK11_GenerateKeyPairWithOpFlags to windows build of NSS. BUG=267888 R=rsleevi@chromium.org Committed: 231777

Patch Set 1 #

Total comments: 1

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	nss/exports_win.def	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Ryan Sleevi

lgtm On Oct 29, 2013 6:49 PM, <eroman@chromium.org> wrote: > Reviewers: Ryan Sleevi, > > ...

11 years, 10 months ago (2013-10-30 01:59:28 UTC) #2

eroman

Committed patchset #1 manually as r231777 (presubmit successful).

11 years, 10 months ago (2013-10-30 06:29:26 UTC) #3

wtc

11 years, 10 months ago (2013-10-30 19:02:30 UTC) #4

Message was sent while issue was closed.

Patch set 1 LGTM.

https://codereview.appspot.com/19620043/diff/1/nss/exports_win.def
File nss/exports_win.def (right):

https://codereview.appspot.com/19620043/diff/1/nss/exports_win.def#newcode134
nss/exports_win.def:134: PK11_GenerateKeyPairWithOpFlags

We can also export PK11_GenerateKeyPairWithFlags. In the future you can export
the related functions so that we don't need to modify this file too often.

Expand All Messages | Collapse All Messages