Issue 19610043: Use patchset.patches instead of random GQL queries.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 19610043: Use patchset.patches instead of random GQL queries. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by iannucci

Modified:
11 years, 10 months ago

Reviewers:
M-A, iposva

CC:
codereview-list_googlegroups.com

Base URL:
hg::https://iannucci%40chromium.org@code.google.com/p/rietveld/@git_stuff

Visibility:
Public.

More Reviews

Description

Use patchset.patches instead of random GQL queries. This should fix the navigation discrepancy between the main patchset ordering and the per-diff ordering. R=maruel@chromium.org BUG=chromium:313078

Patch Set 1 #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	codereview/views.py	View		2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

iannucci

On 2013/10/30 00:59:16, iannucci wrote: +iposva, this should fix the issue you saw :)

11 years, 10 months ago (2013-10-30 01:02:12 UTC) #3

iannucci

Committed https://code.google.com/p/rietveld/source/detail?r=8665f2633aea4a0b54afc678697f71d18cced85b (default) Merged https://code.google.com/p/rietveld/source/detail?r=946aae932691e3f23a42ba74657700a4a571cb50&name=chromium (chromium)

11 years, 10 months ago (2013-10-30 02:13:50 UTC) #4

iannucci

11 years, 10 months ago (2013-10-30 02:26:55 UTC) #5

Message was sent while issue was closed.

On 2013/10/30 02:13:50, iannucci wrote:
> Committed
>
https://code.google.com/p/rietveld/source/detail?r=8665f2633aea4a0b54afc67869...
> (default)
> Merged
>
https://code.google.com/p/rietveld/source/detail?r=946aae932691e3f23a42ba7465...
> (chromium)

This contained a bug, now addressed here: //codereview.appspot.com/19660043

Expand All Messages | Collapse All Messages