code review 196079: Replace the manual body chunk writer code in Request, with

Replace the manual body chunk writer code in Request, with
the reusable NewChunkWriter code.

[petar-m, 2010-01-31 03:21:07]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc1, 2010-02-01 19:26:23]

http://codereview.appspot.com/196079/diff/1001/4
File src/pkg/http/request.go (right):

http://codereview.appspot.com/196079/diff/1001/4#newcode191
src/pkg/http/request.go:191: // TODO(petar): Write trailer here and append \r\n
There's a bug here: until you do the TODO,
you still need to print \r\n here so that a
server reading the request will know it's done.
cw.Close sends 0\r\n but the next \r\n is still necessary
even without a trailer.

Is there an easy test for this code?

[petar-m, 2010-02-02 02:31:52]

http://codereview.appspot.com/196079/diff/1001/4
File src/pkg/http/request.go (right):

http://codereview.appspot.com/196079/diff/1001/4#newcode191
src/pkg/http/request.go:191: // TODO(petar): Write trailer here and append \r\n
Fixed it. I will add a requestwrite_test.go (and responsewrite_test.go) in the
next CL.

On 2010/02/01 19:26:23, rsc1 wrote:
> There's a bug here: until you do the TODO,
> you still need to print \r\n here so that a
> server reading the request will know it's done.
> cw.Close sends 0\r\n but the next \r\n is still necessary
> even without a trailer.
> 
> Is there an easy test for this code?

[rsc, 2010-02-04 07:30:29]

LGTM

thanks

[rsc, 2010-02-04 08:23:03]

*** Submitted as http://code.google.com/p/go/source/detail?r=7ae825e84142 ***

http: use ChunkWriter in Request.Write

R=rsc
CC=golang-dev
http://codereview.appspot.com/196079

Committer: Russ Cox <rsc@golang.org>