Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2298)

Issue 196077: code review 196077: Recognize gccgo error messages. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 3 months ago by iant
Modified:
14 years, 3 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

Recognize gccgo error messages. bug228.go:11:25: error: invalid use of ‘...’ bug228.go:13:13: error: ‘...’ only permits one name bug228.go:15:20: error: ‘...’ must be last parameter bug228.go:17:7: error: expected type bug228.go:19:8: error: expected type

Patch Set 1 #

Patch Set 2 : code review 196077: Recognize gccgo error messages. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M test/fixedbugs/bug228.go View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
iant
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 3 months ago (2010-01-30 05:50:51 UTC) #1
r2
LGTM On 30/01/2010, at 4:50 PM, iant@golang.org wrote: > Reviewers: rsc, > > Message: > ...
14 years, 3 months ago (2010-01-30 06:33:31 UTC) #2
iant
14 years, 3 months ago (2010-01-30 06:38:46 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=27ea16c77a96 ***

Recognize gccgo error messages.

bug228.go:11:25: error: invalid use of ‘...’
bug228.go:13:13: error: ‘...’ only permits one name
bug228.go:15:20: error: ‘...’ must be last parameter
bug228.go:17:7: error: expected type
bug228.go:19:8: error: expected type

R=rsc
CC=golang-dev
http://codereview.appspot.com/196077
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b