Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1304)

Issue 196066: Review: more nan/inf checking (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by larrygritz
Modified:
13 years ago
Reviewers:
ckulla
Base URL:
http://openshadinglanguage.googlecode.com/svn/trunk/
Visibility:
Public.

Description

At Chris Kulla's suggestion, expand our "debugnan" checking to include the binding step, to catch any bad values passed into the shading system.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated with Chris Kulla's suggestions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -20 lines) Patch
src/liboslexec/exec.cpp View 1 7 chunks +43 lines, -20 lines 0 comments Download
src/liboslexec/oslexec_pvt.h View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5
larrygritz
13 years ago (2010-01-29 21:19:16 UTC) #1
ckulla
http://codereview.appspot.com/196066/diff/1/3 File src/liboslexec/exec.cpp (right): http://codereview.appspot.com/196066/diff/1/3#newcode345 src/liboslexec/exec.cpp:345: if (debugnan && check_nan (sym, NULL, 0, m_npoints-1, badval)) ...
13 years ago (2010-02-01 16:26:06 UTC) #2
lg_imageworks.com
Good call on both counts. I will upload an updated review shortly. -- lg On ...
13 years ago (2010-02-01 17:34:24 UTC) #3
larrygritz
Updated with Chris Kulla's suggestions
13 years ago (2010-02-01 17:53:18 UTC) #4
ckulla
13 years ago (2010-02-01 18:02:50 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b