Issue 196052: Upgrade httpclient 3.x to 4.0.1

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 196052: Upgrade httpclient 3.x to 4.0.1 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 7 months ago by Paul Lindner

Modified:
15 years, 4 months ago

Reviewers:
shindig.remailer

Visibility:
Public.

Description

httpclient 3.x is old and deprecated. 4.0 has been out for some time now.

Patch Set 1 #

Patch Set 2 : Minor fixes, make more extensible/injectable #

Created: 15 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+336 lines, -203 lines)			Patch
M	java/common/src/main/java/org/apache/shindig/common/cache/LruCacheProvider.java	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	java/gadgets/pom.xml	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/http/BasicHttpFetcher.java	View	1	1 chunk	+303 lines, -176 lines	0 comments	Download
	java/samples/pom.xml	View		1 chunk	+1 line, -1 line	0 comments	Download
	java/social-api/pom.xml	View		3 chunks	+9 lines, -3 lines	0 comments	Download
M	java/social-api/src/main/java/org/apache/shindig/social/sample/service/SampleContainerHandler.java	View		4 chunks	+13 lines, -14 lines	0 comments	Download
	pom.xml	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Paul Lindner

15 years, 7 months ago (2010-01-29 00:47:03 UTC) #1

Would like to see some eyes on this.  The 4.0 version of httpclient has a lot of
good code that shindig duplicates in many ways.


That said I wouldn't want to couple too tightly...

Expand All Messages | Collapse All Messages