Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(404)

Issue 196043: Missing sqrtf in beckman's sample function (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by aconty
Modified:
11 years, 8 months ago
Reviewers:
osl-dev, ckulla
Base URL:
http://openshadinglanguage.googlecode.com/svn/trunk/
Visibility:
Public.

Description

There was a problem with the sample function in beckman closure. A missing sqrt for sampling the tangent of theta. It was preventing reflections from getting the right blur. This patch fixes the problem.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
src/liboslexec/bsdf_microfacet.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
aconty
12 years, 8 months ago (2010-01-28 02:47:44 UTC) #1
ckulla
12 years, 8 months ago (2010-01-28 02:51:10 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b