Issue 1959042: code review 1959042: A+C: Mikkel Krautz (individual CLA)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1959042: code review 1959042: A+C: Mikkel Krautz (individual CLA) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 7 months ago by rsc

Modified:
14 years, 7 months ago

Reviewers:

CC:
agl, agl1, golang-dev

Visibility:
Public.

Description

A+C: Mikkel Krautz (individual CLA)

Patch Set 1 #

Patch Set 2 : code review 1959042: A+C: Mikkel Krautz (individual CLA) #

Created: 14 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	AUTHORS	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	M	CONTRIBUTORS	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello agl (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 7 months ago (2010-08-13 18:50:35 UTC) #1

agl1

*** Submitted as http://code.google.com/p/go/source/detail?r=cfd0da96d2e7 *** A+C: Mikkel Krautz (individual CLA) R=agl, agl1 CC=golang-dev http://codereview.appspot.com/1959042 Committer: ...

14 years, 7 months ago (2010-08-16 15:21:41 UTC) #3

rsc

14 years, 7 months ago (2010-08-16 15:38:43 UTC) #4

sorry about that; the fact that you can do that is
one of my favorite things about this system.  ;-)

On Mon, Aug 16, 2010 at 08:21,  <agl@golang.org> wrote:
> *** Submitted as
> http://code.google.com/p/go/source/detail?r=cfd0da96d2e7 ***
>
> A+C: Mikkel Krautz (individual CLA)
>
> R=agl, agl1
> CC=golang-dev
> http://codereview.appspot.com/1959042
>
> Committer: Adam Langley <agl@golang.org>
>
>
> http://codereview.appspot.com/1959042/show
>

Expand All Messages | Collapse All Messages