Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2249)

Issue 1954044: code review 1954044: release.2010-08-11 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by adg
Modified:
10 years, 6 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

release.2010-08-11

Patch Set 1 #

Total comments: 4

Patch Set 2 : code review 1954044: release.2010-08-11 #

Patch Set 3 : code review 1954044: release.2010-08-11 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -1 line) Patch
M .hgtags View 1 chunk +0 lines, -1 line 0 comments Download
M doc/devel/release.html View 1 2 1 chunk +72 lines, -0 lines 0 comments Download

Messages

Total messages: 6
adg
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
10 years, 6 months ago (2010-08-12 05:20:01 UTC) #1
rsc1
wait until dashboard okays my compiler change http://codereview.appspot.com/1954044/diff/1/3 File doc/devel/release.html (right): http://codereview.appspot.com/1954044/diff/1/3#newcode16 doc/devel/release.html:16: the once ...
10 years, 6 months ago (2010-08-12 05:28:05 UTC) #2
adg
Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 6 months ago (2010-08-12 05:30:37 UTC) #3
rsc1
LGTM wait for the dashboard still
10 years, 6 months ago (2010-08-12 05:37:29 UTC) #4
gri1
FYI: line 11: s/change to your code/change your code/ - gri On Wed, Aug 11, ...
10 years, 6 months ago (2010-08-12 05:40:15 UTC) #5
adg
10 years, 6 months ago (2010-08-12 05:51:19 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=07d3a97302be ***

release.2010-08-11

R=rsc
CC=golang-dev
http://codereview.appspot.com/1954044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b